Add usage of _MSVC_LANG for windows C++ standard check #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschueller
reviewed
Sep 18, 2019
|
Yes indeed, corrected |
stevengj
approved these changes
Sep 18, 2019
|
Tell me if there is anything else I need to do to have this PR merged. That would help in our dev process. Thanks ! |
elmarputs
pushed a commit
to elmarputs/nlopt
that referenced
this pull request
Oct 16, 2019
* Add usage of _MSVC_LANG for windows C++ standard check * Use MSC_VER instead or WIN32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion on PR #294 , here is an improvement that should work for all compilers (windows or not). Sorry about the error in the first place