Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c89 compatibility #261

Merged
merged 6 commits into from
Apr 12, 2019
Merged

c89 compatibility #261

merged 6 commits into from
Apr 12, 2019

Conversation

stevengj
Copy link
Owner

@stevengj stevengj commented Apr 12, 2019

Fixes #259, adds -std=c89 -pedantic -Werror to compilation flags on Travis to catch future C89 errors.

@stevengj stevengj mentioned this pull request Apr 12, 2019
@jschueller
Copy link
Collaborator

can you include my appveyor changes ?

@jschueller
Copy link
Collaborator

maybe it's not necessary to build vs14 twice for 32 and 64 bits

@stevengj
Copy link
Owner Author

I would prefer to test both win32 and win64 with the same VS version.

@stevengj
Copy link
Owner Author

stevengj commented Apr 12, 2019

Changed the test to be a little less strict and allow POSIX 2001 functions, so that it allows functions like vsnprintf and isinf that are widely available even on C89-ish compilers. (I'm not willing to work very hard to support 20-year-old systems unless there is evidence that it is actually needed.)

@jschueller jschueller merged commit 16e200f into master Apr 12, 2019
@jschueller jschueller deleted the c89 branch April 12, 2019 20:12
@vhaguiar
Copy link

vhaguiar commented Jul 4, 2020

bobyqa seems unstable, given the same initial value, algorithm is deterministic, so it should be stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DIRserial.c(29): error C2275: 'integer' : illegal use of this type as an expression
3 participants