-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for AWS Linux and Debian #29
Conversation
else | ||
pkg_name = 'r_base' | ||
end | ||
package pkg_name do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newline after the end
Left some minor style comments. Would you mind rebasing away the "Correct merge conflict" commit? I can always do that when I merge so no worries if you don't get to it. Is there not a dev package on Amazon/RHEL systems that we can install? |
Thanks! Will clean this up soon. There's no dev package that I've found in the Amazon repos, but I haven't checked out EPEL yet. |
Sorry this took so long. All cleaned up and squashed now. Please review and merge if it passes muster. Thanks again! |
Hi, @stevendanna. Will you have time to review and possibly merge this PR soon? I'd like to start working on the testing functions and would rather not have to track multiple PRs. :) Thanks for the continued engagement! |
@davidski Heya. I just pushed a basic travis setup. I'm running your branch against our basic test-kitchen setup right now with one minor rubocop fix appended. Once it passes, I'll merge it. |
@davidski It looks for the current kitchen tests to pass on centos, we'd have to install EPEL (IIRC this is where the CRAN README's on centos support will send you to). Since the |
Oy. I can't believe I had left this out so long. Trying to close out the year with a few less To Dos. 😄 I've done a bit of refactoring on this PR.
Hopefully you'll be able to review and merge a bit faster than I was in getting this back to you. 😁 |
For centos-7.2, I had to change |
@davidski Thanks for pulling this together. I'll take a look and try to get another release out this month. |
Hey there, @stevendanna. Might you be able to review and possibly merge this soon? Was dealing with a StackOverflow question recently where I think this would have been helpful. Thanks a bunch! |
@davidski Yup, sorry I forgot about this. I put it on my todo list for the week. |
I went ahead and merged this as is, I'll try to take a look at this cookbook tomorrow and get it back in shape. |
Sorry for missing this thread, @stevendanna! The Travis builds look to be passing (https://travis-ci.org/stevendanna/cookbook-r/builds/207778940 is green). Is there anything I'm missing here that I can help out with? |
Support the AWS Linux and Debian platforms. Centos not yet supported (requires EPEL).