Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AWS Linux and Debian #29

Merged
merged 11 commits into from
Mar 4, 2017
Merged

Add support for AWS Linux and Debian #29

merged 11 commits into from
Mar 4, 2017

Conversation

davidski
Copy link
Contributor

@davidski davidski commented Oct 5, 2015

Support the AWS Linux and Debian platforms. Centos not yet supported (requires EPEL).

else
pkg_name = 'r_base'
end
package pkg_name do
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline after the end

@stevendanna
Copy link
Owner

Left some minor style comments. Would you mind rebasing away the "Correct merge conflict" commit? I can always do that when I merge so no worries if you don't get to it.

Is there not a dev package on Amazon/RHEL systems that we can install?

@davidski
Copy link
Contributor Author

davidski commented Oct 5, 2015

Thanks! Will clean this up soon.

There's no dev package that I've found in the Amazon repos, but I haven't checked out EPEL yet.

@davidski
Copy link
Contributor Author

Sorry this took so long. All cleaned up and squashed now. Please review and merge if it passes muster. Thanks again!

@davidski
Copy link
Contributor Author

Hi, @stevendanna. Will you have time to review and possibly merge this PR soon? I'd like to start working on the testing functions and would rather not have to track multiple PRs. :) Thanks for the continued engagement!

@stevendanna
Copy link
Owner

@davidski Heya. I just pushed a basic travis setup. I'm running your branch against our basic test-kitchen setup right now with one minor rubocop fix appended. Once it passes, I'll merge it.

@stevendanna
Copy link
Owner

@davidski It looks for the current kitchen tests to pass on centos, we'd have to install EPEL (IIRC this is where the CRAN README's on centos support will send you to). Since the yum cookbook already provides a yum_repository resource, it should be pretty straightforward.

@davidski
Copy link
Contributor Author

Oy. I can't believe I had left this out so long. Trying to close out the year with a few less To Dos. 😄

I've done a bit of refactoring on this PR.

  • Ubuntu 10 dropped and Ubuntu 16 added
  • rubocop/foodcritic/cookstyle linting
  • Added the EPEL repository via the supermarket yum-epel recipe
  • Updated Travis build environment for some ruby dependencies

Hopefully you'll be able to review and merge a bit faster than I was in getting this back to you. 😁

@sfromm-plm
Copy link

For centos-7.2, I had to change default['r']['install_dir'] in attributes/install.rb to '/usr/lib64/R'.

@stevendanna
Copy link
Owner

@davidski Thanks for pulling this together. I'll take a look and try to get another release out this month.

@davidski
Copy link
Contributor Author

Hey there, @stevendanna. Might you be able to review and possibly merge this soon? Was dealing with a StackOverflow question recently where I think this would have been helpful. Thanks a bunch!

@stevendanna
Copy link
Owner

@davidski Yup, sorry I forgot about this. I put it on my todo list for the week.

@stevendanna stevendanna merged commit 5603349 into stevendanna:master Mar 4, 2017
@stevendanna
Copy link
Owner

I went ahead and merged this as is, I'll try to take a look at this cookbook tomorrow and get it back in shape.

@davidski
Copy link
Contributor Author

davidski commented Mar 7, 2017

Sorry for missing this thread, @stevendanna! The Travis builds look to be passing (https://travis-ci.org/stevendanna/cookbook-r/builds/207778940 is green). Is there anything I'm missing here that I can help out with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants