Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exercise 12: URL to send a request to is not visible #146

Open
ghost opened this issue Jul 14, 2018 · 3 comments
Open

Exercise 12: URL to send a request to is not visible #146

ghost opened this issue Jul 14, 2018 · 3 comments

Comments

@ghost
Copy link

ghost commented Jul 14, 2018

This is what I got when trying to solve the 12th exercise (notice the http:// and the https:// for the documentation):

screen shot 2018-07-14 at 23 16 14

I had to look up the URL here in the repo (localhost:1337) in order to pass.
@senpl
Copy link

senpl commented Sep 25, 2018

@tdd This is serious issue that make this exercise unusable. Please provide text into description that clearly state localhost:1337 . Some simple fix is needed to not waste users time.

senpl added a commit to senpl/promise-it-wont-hurt that referenced this issue Sep 25, 2018
@senpl
added localhost that are expected in solution.
39d33a9 
It not showed up as shown in stevekane#146
senpl added a commit to senpl/promise-it-wont-hurt that referenced this issue Sep 25, 2018
@senpl
added localhost in france language
a778791 
It not showed up as shown in stevekane#146
senpl added a commit to senpl/promise-it-wont-hurt that referenced this issue Sep 25, 2018
@senpl
added localhost in japan language
a244c98 
It not showed up as shown in stevekane#146
senpl added a commit to senpl/promise-it-wont-hurt that referenced this issue Sep 25, 2018
@senpl
added localhost in france language
8e84eda 
It not showed up as shown in stevekane#146
senpl added a commit to senpl/promise-it-wont-hurt that referenced this issue Sep 25, 2018
@senpl
added localhost in japan language
8abcfad 
It not showed up as shown in stevekane#146
senpl added a commit to senpl/promise-it-wont-hurt that referenced this issue Sep 25, 2018
@senpl
upgraded to mark that version that fix issue 146
a9d505a 
This version should fix that issue in stevekane#146
@senpl
Copy link

senpl commented Sep 25, 2018

This pull request should solve that issue #151

@DavidPinilla1
Copy link

thanks! I was also stuck due to the same reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@senpl @DavidPinilla1