Use real_type_t as the data type for real type signals
#681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently only the netvector_t type implements the get_scalar() method. To check whether a type is scalar it is first cast to netvector_t and then the method is called. But there are other types, such as areal that can also be scalar. To support indicating that a real type is scalar add a virtual get_scalar() method to ivl_type_s, which is the base class for all types. Signed-off-by: Lars-Peter Clausen <[email protected]>
reals are both signed and scalar. But the real_type_t currently reports as neither. This isn't much of a problem because most real signals are implemented using netvector_t with the base type set to IVL_VT_REAL, for which the signedness is correctly reported. Function return values and class properties use the netreal_t as their data type, but most places that work with reals check the base type and assume that the value is signed when the base type is real. The only place where this really makes a difference at the moment is the Verilog-AMS function when being passed a function call as its argument. In that case the `abs()` function will be optimized away and a negative value will be passed through as negative. But going forward netreal_t is also going to be used for the data type of real type signals. To fix the `abs()` issue and to be ready to switch real signals over to using netreal_t as their type implement the appropriate methods on netreal_t. Signed-off-by: Lars-Peter Clausen <[email protected]>
Currently a `vector_type_t` with the base type set to `IVL_VT_REAL` is used as the data type for real type signals. But there is also the `real_type_t` data type, which is used as the data type for function return types and class properties. Move signals also over to using `real_type_t`. This ensures consistent behavior between all sorts of constructs with a data type, makes sure that `vector_type_t` is only used for vector types. It also allows to eventually differentiate between `real` and `shortreal` at the elaboration stage. Currently this information is discarded by the parser. Signed-off-by: Lars-Peter Clausen <[email protected]>
Check that the behavior of the Verilog AMS `abs()` function is correct when its argument is a function call. Check this for both vector as well as real types. This test is largely a copy of the existing vams_abs2 test, just replacing the identifier argument with a function call argument. Signed-off-by: Lars-Peter Clausen <[email protected]>
larsclausen
changed the title
real_type_t as the data type for real type signalsreal_type_t as the data type for real type signals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a
vector_type_twith the base type set toIVL_VT_REALis used asthe data type for real type signals. But there is also the
real_type_tdatatype, which is used as the data type for function return types and class
properties.
Move signals also over to using
real_type_t. This ensures consistentbehavior between all sorts of constructs with a data type, makes sure that
vector_type_tis only used for vector types.It also allows to eventually differentiate between
realandshortrealat the elaboration stage. Currently this information is discarded by the
parser.
As a side effect this PR also fixes the rather obscure case of passing a call
to a function with a real return type as the argument to the Verilog AMS
abs()function.