Move jitopt and rpo experiments to PerfVipers (dotnet#102575)

* Move jitopt and rpo experiments to PerfVipers * Remove rpolayout experiment
steveharter · May 28, 2024 · 55ef80b · 55ef80b
1 parent 327bb82
commit 55ef80b
Show file tree

Hide file tree

Showing 13 changed files with 38 additions and 314 deletions.
diff --git a/eng/pipelines/coreclr/perf-non-wasm-jobs.yml b/eng/pipelines/coreclr/perf-non-wasm-jobs.yml
@@ -255,23 +255,6 @@ jobs:
         logicalmachine: 'perftiger'
         r2rRunType: --nor2r
 
-  # run coreclr perftiger microbenchmarks memory randomization jobs
-  - template: /eng/pipelines/common/platform-matrix.yml
-    parameters:
-      jobTemplate: /eng/pipelines/coreclr/templates/perf-job.yml
-      buildConfig: release
-      runtimeFlavor: coreclr
-      platforms:
-      - windows_x64
-      jobParameters:
-        testGroup: perf
-        liveLibrariesBuildConfig: Release
-        projectFile: microbenchmarks.proj
-        runKind: micro
-        runJobTemplate: /eng/pipelines/coreclr/templates/run-performance-job.yml
-        logicalmachine: 'perftiger'
-        experimentName: 'memoryRandomization'
-
   # run coreclr perfowl microbenchmarks perf job
   - template: /eng/pipelines/common/platform-matrix.yml
     parameters:
@@ -324,7 +307,7 @@ jobs:
         logicalmachine: 'perfowl'
         experimentName: 'rlcse'
 
-  # run coreclr perfowl microbenchmarks perf jitoptrepeat jobs
+  # run coreclr perfviper microbenchmarks perf jitoptrepeat jobs
   - template: /eng/pipelines/common/platform-matrix.yml
     parameters:
       jobTemplate: /eng/pipelines/coreclr/templates/perf-job.yml
@@ -339,27 +322,9 @@ jobs:
         projectFile: microbenchmarks.proj
         runKind: micro
         runJobTemplate: /eng/pipelines/coreclr/templates/run-performance-job.yml
-        logicalmachine: 'perfowl'
+        logicalmachine: 'perfviper'
         experimentName: 'jitoptrepeat'
 
-  # run coreclr perfowl microbenchmarks perf rpolayout jobs
-  - template: /eng/pipelines/common/platform-matrix.yml
-    parameters:
-      jobTemplate: /eng/pipelines/coreclr/templates/perf-job.yml
-      buildConfig: release
-      runtimeFlavor: coreclr
-      platforms:
-      - linux_x64
-      - windows_x64
-      jobParameters:
-        testGroup: perf
-        liveLibrariesBuildConfig: Release
-        projectFile: microbenchmarks.proj
-        runKind: micro
-        runJobTemplate: /eng/pipelines/coreclr/templates/run-performance-job.yml
-        logicalmachine: 'perfowl'
-        experimentName: 'rpolayout'
-
   # run coreclr crossgen perf job
   - template: /eng/pipelines/common/platform-matrix.yml
     parameters:

diff --git a/src/libraries/System.Data.Common/tests/System/Data/DataColumnTest.cs b/src/libraries/System.Data.Common/tests/System/Data/DataColumnTest.cs
@@ -796,51 +796,31 @@ public void NonSqlNullableType_RequiresPublicStaticNull()
         [Fact]
         public void MethodsCalledByReflectionAreNotTrimmed()
         {
-            DataColumn dataColumn = new DataColumn
+            DataColumn dc = new DataColumn
             {
                 ColumnName = "dataColumn",
                 DataType = typeof(DateTime)
             };
 
-            var properties = TypeDescriptor.GetProperties(dataColumn);
-            var property = properties[nameof(DataColumn.DefaultValue)];
-            if (property != null)
-            {
-                Assert.False(property.ShouldSerializeValue(dataColumn));
-
-                dataColumn.DefaultValue = DateTime.MinValue;
-                Assert.True(property.ShouldSerializeValue(dataColumn));
-
-                // Reset method is not available
-                property.ResetValue(dataColumn);
-                Assert.Equal(DateTime.MinValue, dataColumn.DefaultValue);
-            }
-
-            property = properties[nameof(DataColumn.Caption)];
-            if (property != null)
-            {
-                Assert.False(property.ShouldSerializeValue(dataColumn));
-
-                dataColumn.Caption = "Caption";
-                Assert.True(property.ShouldSerializeValue(dataColumn));
-
-                // Reset method is available
-                property.ResetValue(dataColumn);
-                Assert.Equal(nameof(dataColumn), dataColumn.Caption);
-            }
-
-            property = properties[nameof(DataColumn.Namespace)];
-            if (property != null)
-            {
-                Assert.False(property.ShouldSerializeValue(dataColumn));
-
-                dataColumn.Namespace = "Namespace";
-                Assert.True(property.ShouldSerializeValue(dataColumn));
-
-                // Reset method is available
-                property.ResetValue(dataColumn);
-                Assert.Equal("", dataColumn.Namespace);
-            }
+            PropertyDescriptorCollection properties = TypeDescriptor.GetProperties(dc);
+
+            Assert.False(properties[nameof(DataColumn.DefaultValue)].ShouldSerializeValue(dc));
+            dc.DefaultValue = DateTime.MinValue;
+            Assert.True(properties[nameof(DataColumn.DefaultValue)].ShouldSerializeValue(dc));
+            properties[nameof(DataColumn.DefaultValue)].ResetValue(dc); // Reset method is not available
+            Assert.Equal(DateTime.MinValue, dc.DefaultValue);
+
+            Assert.False(properties[nameof(DataColumn.Caption)].ShouldSerializeValue(dc));
+            dc.Caption = "Caption";
+            Assert.True(properties[nameof(DataColumn.Caption)].ShouldSerializeValue(dc));
+            properties[nameof(DataColumn.Caption)].ResetValue(dc); // Reset method is available
+            Assert.Equal("dataColumn", dc.Caption);
+
+            Assert.False(properties[nameof(DataColumn.Namespace)].ShouldSerializeValue(dc));
+            dc.Namespace = "Namespace";
+            Assert.True(properties[nameof(DataColumn.Namespace)].ShouldSerializeValue(dc));
+            properties[nameof(DataColumn.Namespace)].ResetValue(dc); // Reset method is available
+            Assert.Equal("", dc.Namespace);
         }
 
         private sealed class NullableTypeWithNullProperty : INullable

diff --git a/src/libraries/System.Data.Common/tests/System/Data/DataTableTest.cs b/src/libraries/System.Data.Common/tests/System/Data/DataTableTest.cs
@@ -1841,7 +1841,7 @@ public void MethodsCalledByReflectionAreNotTrimmed()
 
             Assert.False(properties[nameof(DataTable.PrimaryKey)].ShouldSerializeValue(dt));
             Assert.False(properties[nameof(DataTable.CaseSensitive)].ShouldSerializeValue(dt));
-            Assert.True(properties[nameof(DataTable.Locale)].ShouldSerializeValue(dt)); // No ResetLocale() method
+            Assert.True(properties[nameof(DataTable.Locale)].ShouldSerializeValue(dt)); // Reset method is not available
             Assert.False(properties[nameof(DataTable.Namespace)].ShouldSerializeValue(dt));
         }
 

diff --git a/src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcCommand.cs b/src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcCommand.cs
@@ -41,6 +41,8 @@ public sealed class OdbcCommand : DbCommand, ICloneable
 
         private ConnectionState _cmdState;
 
+        [DynamicDependency(nameof(ResetCommandTimeout))]
+        [DynamicDependency(nameof(ShouldSerializeCommandTimeout))]
         public OdbcCommand() : base()
         {
             GC.SuppressFinalize(this);

diff --git a/src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcParameter.cs b/src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcParameter.cs
@@ -68,6 +68,10 @@ public sealed partial class OdbcParameter : DbParameter, ICloneable, IDataParame
 
         private ODBC32.SQL_C _prepared_Sql_C_Type;
 
+        [DynamicDependency(nameof(ResetDbType))] // Calls DbParameter.ResetOdbcType()
+        [DynamicDependency(nameof(ShouldSerializePrecision))]
+        [DynamicDependency(nameof(ShouldSerializeScale))]
+        [DynamicDependency(nameof(ShouldSerializeSize))]
         public OdbcParameter() : base()
         {
             // uses System.Threading!

diff --git a/src/libraries/System.Data.Odbc/tests/TrimmingTests/OdbcCommandTest.cs b/src/libraries/System.Data.Odbc/tests/TrimmingTests/OdbcCommandTest.cs
diff --git a/src/libraries/System.Data.Odbc/tests/TrimmingTests/OdbcParameterTest.cs b/src/libraries/System.Data.Odbc/tests/TrimmingTests/OdbcParameterTest.cs
diff --git a/src/libraries/System.Data.Odbc/tests/TrimmingTests/System.Data.Odbc.TrimmingTests.proj b/src/libraries/System.Data.Odbc/tests/TrimmingTests/System.Data.Odbc.TrimmingTests.proj
diff --git a/src/libraries/System.Data.OleDb/src/OleDbCommand.cs b/src/libraries/System.Data.OleDb/src/OleDbCommand.cs
@@ -46,6 +46,8 @@ public sealed class OleDbCommand : DbCommand, ICloneable, IDbCommand
         private int _changeID;
         private int _lastChangeID;
 
+        [DynamicDependency(nameof(ResetCommandTimeout))]
+        [DynamicDependency(nameof(ResetConnection))]
         public OleDbCommand() : base()
         {
             GC.SuppressFinalize(this);

diff --git a/src/libraries/System.Data.OleDb/src/OleDbParameter.cs b/src/libraries/System.Data.OleDb/src/OleDbParameter.cs
@@ -22,6 +22,13 @@ public sealed partial class OleDbParameter : DbParameter, ICloneable, IDbDataPar
 
         private NativeDBType? _coerceMetaType;
 
+        [DynamicDependency(nameof(ResetDbType))] // Calls ResetOleDbType()
+        [DynamicDependency(nameof(ResetParent))]
+        [DynamicDependency(nameof(ResetSize))]
+        [DynamicDependency(nameof(ShouldSerializeOleDbType))]
+        [DynamicDependency(nameof(ShouldSerializePrecision))]
+        [DynamicDependency(nameof(ShouldSerializeScale))]
+        [DynamicDependency(nameof(ShouldSerializeSize))]
         public OleDbParameter() : base()
         { // V1.0 nothing
         }

diff --git a/src/libraries/System.Data.OleDb/tests/TrimmingTests/OleDbCommandTest.cs b/src/libraries/System.Data.OleDb/tests/TrimmingTests/OleDbCommandTest.cs