Leverage non-lexical scoping to clean up example in Filesystem and Processes section #103
+8
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocesses section Non-lexical lifetimes were added in rust 1.31 (2018 edition) and 1.36 (2015 edition) which have been available for over a year (1.36 released 4 July 2019). This small change updates the code sample and removes a comment explaining the use of scoping to assist the borrow checker. The removed comment was helpful to explain the reasoning behind the local scoping, but was ultimately off topic for the section. core::str<_>::trim_right was deprecated in Rust 1.33 and superceded by trim_end(). Update file4.rs, and file5.rs to use trim_end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leverage non-lexical scoping to clean up example in Filesystem and Processes section
Non-lexical lifetimes were added in rust 1.31 (2018 edition) and 1.36 (2015 edition)
which have been available for over a year (1.36 released 4 July 2019). This small change
updates the code sample and removes a comment explaining the use of scoping to assist the
borrow checker. The removed comment was helpful to explain the reasoning behind the local
scoping, but was ultimately off topic for the section.
core::str<_>::trim_right was deprecated in Rust 1.33 and superceded by trim_end(). Update
file4.rs, and file5.rs to use trim_end.