Add custom CSS Definitions #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your work on this @EPGDigital-MW! I'll review this today 🙏 |
stevebauman
reviewed
Nov 17, 2023
src/Definitions/CSSDefinition.php
Outdated
|
|
||
| use HTMLPurifier_CSSDefinition; | ||
|
|
||
| interface CSSDefinition |
There was a problem hiding this comment.
Can we adjust this interface name to be PascalCase for consistency since we have HtmlDefinition and Html5Definition? Once changed I'll merge! 👍
Suggested change
| interface CSSDefinition | |
| interface CssDefinition |
There was a problem hiding this comment.
This should be updated now to PascalCase, thanks
There was a problem hiding this comment.
Awesome thanks @EPGDigital-MW! 🙏
|
Released https://github.com/stevebauman/purify/releases/tag/v6.1.0, thanks again for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to create custom CSS definitions to be able to setup a custom CSS definition.
In my case I was finding text-align was missing start and end values, it only supported right. left, and center out of the box so I needed to add start and end
https://developer.mozilla.org/en-US/docs/Web/CSS/text-align.
I've included an example in the readme on how to implement the text-align change, taking the code from HTMLPurify, and modifying the CSS allowed enum for text-align.