Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #76 Updated fields in bower.json #77

Merged
merged 3 commits into from
Dec 30, 2015
Merged

Conversation

arjshiv
Copy link

@arjshiv arjshiv commented Dec 29, 2015

Minor changes to bower.json per official spec

Minor changes to bower.json per official spec
@codewithtyler
Copy link
Contributor

Why did you add style.css to the list of main files?

@arjshiv
Copy link
Author

arjshiv commented Dec 29, 2015

So that a WebPack plugin can pull in the default styling when it's required. It's not critical to this update, so I can remove it if you don't want that to be the default behavior.

@codewithtyler
Copy link
Contributor

The styling in style.css only applies to the examples folder. For the main application itself it's not needed.

Edit: That being said we should probably nest the css folder in the examples folder at some point to avoid future confusion.

@arjshiv
Copy link
Author

arjshiv commented Dec 29, 2015

Ok, I'll remove it then

@arjshiv
Copy link
Author

arjshiv commented Dec 29, 2015

The change has now been made

@codewithtyler
Copy link
Contributor

Thank you. Everything looks good.

@steveathon Everything looks good to merge :shipit:

@arjshiv
Copy link
Author

arjshiv commented Dec 29, 2015

Absolutely - glad to help anywhere I can - you have a really useful library!

@codewithtyler
Copy link
Contributor

I hope it only gets more useful over the coming months. @steveathon and I have some plans to expand the library very soon.

steveathon added a commit that referenced this pull request Dec 30, 2015
Issue #76 Updated fields in bower.json
@steveathon steveathon merged commit b26cc45 into steveathon:master Dec 30, 2015
@steveathon
Copy link
Owner

Thanks team! Looks good. Merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants