Square bleep is truly a square...

steve-mackinnon · Mar 24, 2024 · d28273d · d28273d
1 parent 8ccbe29
commit d28273d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/engine/sequencerEngine.ts b/src/engine/sequencerEngine.ts
@@ -22,8 +22,9 @@ function makeGenerator(
     case GeneratorType.ClosedHH:
       return new HiHat(destination);
     case GeneratorType.SineBleep:
+      return new Pluck(destination, "sine");
     case GeneratorType.SquareBleep:
-      return new Pluck(destination);
+      return new Pluck(destination, "square");
     case GeneratorType.Snare:
       return new Snare(destination);
   }

diff --git a/src/generators/pluck/pluck.ts b/src/generators/pluck/pluck.ts
@@ -11,7 +11,7 @@ export class Pluck implements Generator {
   private readonly _ampEnv: AmplitudeEnvelope;
   private readonly _osc: PolySynth;
 
-  constructor(destination: ToneAudioNode) {
+  constructor(destination: ToneAudioNode, type: "sine" | "square") {
     this._gain = new Gain(1.0).connect(destination);
     this._ampEnv = new AmplitudeEnvelope({
       attack: 0.01,
@@ -23,7 +23,7 @@ export class Pluck implements Generator {
     this._osc.maxPolyphony = 10;
     this._osc.set({
       oscillator: {
-        type: "sine",
+        type,
       },
     });
   }