Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use testcontainers maven plugin for the generation of jooq code #1190

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use testcontainers maven plugin for the generation of jooq code #1190

wants to merge 3 commits into from

Conversation

juherr
Copy link
Contributor

@juherr juherr commented Jul 16, 2023

It should make compilation easier for newcomers.
Close #1140

@goekay
Copy link
Member

goekay commented Jul 25, 2023

hey @juherr i think this PR and the changes it introduces are cleaner than the one in #1140. therefore, i am slightly leaning towards this one.

there are failed checks though.

@juherr
Copy link
Contributor Author

juherr commented Jul 25, 2023

Yes, I wanted some feedbacks before going deeper.
I will try to fix the issues.

@goekay
Copy link
Member

goekay commented Jul 25, 2023

when the build pipeline and infra-related stuff are updated, we can refactor tests to include testcontainers. nice initiative!

@juherr
Copy link
Contributor Author

juherr commented Jul 26, 2023

Java 11 builds are failing because the plugin is build against Java 17.
As Java 11 support will be dropped in 2 months, maybe we can assume to drop its support at build time (Java 11 can be still the target but build by Java 17)

Java 17 builds are failing because the database was no more ready (as not used at build time).
I try to manage the migration before the tests based on your work at d5a6617
The build is ongoing ;) 🤞

@juherr juherr force-pushed the feature/testcontainers-generation branch 4 times, most recently from 98b125e to 3a8faaa Compare July 27, 2023 07:27
@juherr
Copy link
Contributor Author

juherr commented Jul 27, 2023

@goekay Everything fixed! 🎉

@juherr juherr force-pushed the feature/testcontainers-generation branch 2 times, most recently from 58acf95 to 49b744c Compare July 28, 2023 16:12
@juherr
Copy link
Contributor Author

juherr commented Jul 31, 2023

Ping @goekay WDYT?

@goekay
Copy link
Member

goekay commented Aug 1, 2023

Ping @goekay WDYT?

pls give me some time. nowadays i am constantly short on time.

@slachiewicz
Copy link
Contributor

With update to Java 17 - Docker file also can be adjusted

@juherr
Copy link
Contributor Author

juherr commented Aug 1, 2023

@slachiewicz step by step 😉

@juherr
Copy link
Contributor Author

juherr commented Aug 20, 2023

Ping @goekay

@juherr juherr force-pushed the feature/testcontainers-generation branch from 49b744c to 470429e Compare September 11, 2023 12:37
@juherr juherr force-pushed the feature/testcontainers-generation branch from 470429e to 3a9837e Compare September 11, 2023 12:49
@juherr
Copy link
Contributor Author

juherr commented Sep 11, 2023

Ping @goekay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slachiewicz slachiewicz slachiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juherr @goekay @slachiewicz