-
-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Steve returns HttpStatus.UNAUTHORIZED when ChargeBoxId is not allowed to connect #1020
Closed
3 of 4 tasks
Comments
good catch, fixing it. thanks! |
goekay
added a commit
that referenced
this issue
Jan 4, 2023
goekay
added a commit
that referenced
this issue
Jan 4, 2023
goekay
added a commit
that referenced
this issue
Jan 8, 2023
goekay
added a commit
that referenced
this issue
Jan 8, 2023
goekay
added a commit
that referenced
this issue
Jan 8, 2023
…statusunauthorized-when-chargeboxid-is-not-allowed-to-connect set the correct http status if chargeboxid is not recognized (#1020)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
Checklist
Specifications
Expected Behavior
According to "Open Charge Point Protocol JSON1.6, OCPP-J 1.6 Specification" if the Central System does not recognize the charge point identifier in the URL path, it SHOULD send an HTTP response with status 404 and abort the WebSocket connection as described in [RFC6455].
Actual Behavior
Steve returns HttpStatus.UNAUTHORIZED = 401
See OcppWebSocketHandshakeHandler.java
if (!allowConnection) {
log.error("ChargeBoxId '{}' is not recognized.", chargeBoxId);
response.setStatusCode(HttpStatus.UNAUTHORIZED);
return false;
}
The OCPP Spec indicates that the Central System SHOULD return 404, why does Steve returns 401 ?
The text was updated successfully, but these errors were encountered: