address review comment

stephenworsley · May 30, 2024 · d812343 · d812343
1 parent 0520967
commit d812343
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/esmf_regrid/experimental/io.py b/esmf_regrid/experimental/io.py
@@ -97,7 +97,6 @@ def _clean_var_names(cube):
             coord.var_name = None
         for con in cube.mesh.connectivities():
             con.var_name = None
-    return cube
 
 
 def save_regridder(rg, filename):
@@ -293,8 +292,10 @@ def load_regridder(filename):
         cubes = iris.load(filename)
 
     # Extract the source, target and metadata information.
-    src_cube = _clean_var_names(cubes.extract_cube(SOURCE_NAME))
-    tgt_cube = _clean_var_names(cubes.extract_cube(TARGET_NAME))
+    src_cube = cubes.extract_cube(SOURCE_NAME)
+    _clean_var_names(src_cube)
+    tgt_cube = cubes.extract_cube(TARGET_NAME)
+    _clean_var_names(tgt_cube)
     weights_cube = cubes.extract_cube(WEIGHTS_NAME)
     weight_shape_cube = cubes.extract_cube(WEIGHTS_SHAPE_NAME)
 

diff --git a/esmf_regrid/tests/unit/experimental/io/test_save_regridder.py b/esmf_regrid/tests/unit/experimental/io/test_save_regridder.py
@@ -57,8 +57,6 @@ def test_managed_var_name():
 
     with _managed_var_name(src, tgt):
         for coord in src.mesh.coords():
-            print(coord)
             assert coord.var_name != DUMMY_VAR_NAME_SRC
         for coord in tgt.mesh.coords():
-            print(coord)
             assert coord.var_name != DUMMY_VAR_NAME_TGT