fix: implement abort grpc web #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @stephenh could you review review this pr, or could I do something to get it reviewed ? |
|
Hey @hersentino yeah, sorry about that! I typically only have time to triage ts-proto issues about every/other weekend or so. Thanks for the ping and the fix! |
stephenh
pushed a commit
that referenced
this pull request
Mar 11, 2023
## [1.141.1](v1.141.0...v1.141.1) (2023-03-11) ### Bug Fixes * implement abort grpc web ([#785](#785)) ([6a40d72](6a40d72))
|
🎉 This PR is included in version 1.141.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#777 introduce abort for grpc web but I forgot to change argument order for one fonction, here is the fix. I'm really sorry about that, everything tested locally and working this time.