fix: Add missing defaults to fromPartial if options.oneof is UNIONS #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
commented
Oct 25, 2021
| @@ -248,6 +264,8 @@ export const PleaseChoose = { | |||
| } | |||
| if (object.age !== undefined && object.age !== null) { | |||
| message.age = object.age; | |||
| } else { | |||
| message.age = 0; | |||
There was a problem hiding this comment.
Same code as in oneof-properties now
webmaster128
commented
Oct 25, 2021
Comment on lines
+289
to
+291
| } else { | ||
| message.signature = new Uint8Array(); | ||
| } |
There was a problem hiding this comment.
Before this change, those 3 lines were missing.
webmaster128
changed the title
stephenh
approved these changes
Oct 26, 2021
|
Thanks! But it says Only those with write access to this repository can merge pull requests. and I don't get a Mergie button or automerge option. |
|
Nevermind, I just had to accept the invitation. |
stephenh
pushed a commit
that referenced
this pull request
Oct 26, 2021
## [1.83.2](v1.83.1...v1.83.2) (2021-10-26) ### Bug Fixes * Add missing defaults to fromPartial if options.oneof is UNIONS ([#375](#375)) ([21781e9](21781e9))
|
🎉 This PR is included in version 1.83.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, setting
options.oneoftoUNIONSwould cause that the else block infromPartialwas never written, no matter if the field is part of the oneof or not. To illustrate, a simplebytes signaturefield was added to oneof-unions, which requires anelsecase to be properly initialized. With the change inmain.ts, the missing code is now generated.