Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows build didn't work out of the box #37

Closed
yoavmil opened this issue Mar 11, 2020 · 1 comment
Closed

Windows build didn't work out of the box #37

yoavmil opened this issue Mar 11, 2020 · 1 comment

Comments

@yoavmil
Copy link

yoavmil commented Mar 11, 2020

Got this error:
--ts_proto_out: protoc-gen-ts_proto: %1 is not a valid Win32 application.

found this answer in similar question. So I added .cmd to the --plugin directive, and it worked. For future users, please update readme, or fix this. Thanks.
@stephenh
Copy link
Owner

Great, thanks for the report. I was unsure of that since it seemed like some Windows people used that suffix and some didn't. I don't have Windows install handy to make sure myself, so rely on these bug reports to know. Updated in the readme. Thanks!

zfy0701 added a commit to sentioxyz/ts-proto that referenced this issue Jan 5, 2023
@zfy0701
chore: minor cleanup (stephenh#37)
651f1f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stephenh @yoavmil