Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oneof=properties suggestion #136

Closed
PhilipMantrov opened this issue Sep 17, 2020 · 1 comment
Closed

oneof=properties suggestion #136

PhilipMantrov opened this issue Sep 17, 2020 · 1 comment

Comments

@PhilipMantrov
Copy link
Contributor

PhilipMantrov commented Sep 17, 2020 •
edited
Loading

From:

export interface ChangePasswordResponse {
  success: boolean | undefined;
  twoFAType: TwoFAType | undefined;
}

To:

export interface ChangePasswordResponse {
  success?: boolean;
  twoFAType?: TwoFAType;
}
@stephenh
Copy link
Owner

Dup of #120 (comment). See the discussion there.

zfy0701 added a commit to sentioxyz/ts-proto that referenced this issue Jan 5, 2023
@zfy0701
feat(sdk): provide price feed api (stephenh#136)
8c9e254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stephenh @PhilipMantrov