Resolve build issues #1
Conversation
In order to fix #319 in SQLite.swift.
Turns out that this project was building SQLite.swift and not SQLiteCipher.swift. It now has two schemes, one for iOS and one for Mac. Both build the same SQLiteCipher.framework.
agisboye
changed the title
agisboye
changed the title
|
@stephencelis any update on this?? |
| @@ -1,6 +1,3 @@ | |||
| [submodule "Vendor/sqlcipher"] | |||
There was a problem hiding this comment.
Can I ask why this was removed as a submodule? (just want to learn...)
There was a problem hiding this comment.
Carthage wasn't building the amalgamation target properly, if I recall correctly. The easiest solution was to remove sqlcipher as a submodule and manually add some files that Xcode complained were missing. Now with Xcode 7.3, though, it doesn't build at all. I haven't been able to get it working.
There was a problem hiding this comment.
I've experienced the same thing, regardless of whether or not I use your way in this PR or use sqlcipher as a submodule. Still working on it. Thanks for the response.
|
This was completely off my radar. Thanks for your work on this so far @agisboye! |
|
It'd be great if we could get it working again. What I did back in January was add build schemes and make them shared (so as to expose them to Carthage). I also added sqlcipher manually because Carthage (via xcodebuild) was complaining about a missing sqlite.c file. With the release of Xcode 7.3, my fork is no longer working, and I have yet to figure out how to resolve the build issues. |
|
See PR #11 - I believe I figured out how to make it compile |
|
Hi Stephen, When is possibe to have this and #11 merged, so that building with cocoapods / carthage is fully functional? Cheers, |
In order to fix #319 in SQLite.swift submodule.