This repository has been archived by the owner on Jan 14, 2018. It is now read-only.
Update 'android-maven-plugin' plugin and few others #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 2, 2016 19:16
be deleted to log. -- Fix 'find-bugs-plugin' check warnings in 'removeAllDataFromCache()' to prepare a transition to 'find-bugs-plugin:3.0.3'
-- Fix build with Oracle Java 8 -- Add 'findbugs-exclude.xml' rules
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RS wasn't building with Java 8, and it soon became annoying to set JAVA_HOME to Java 7 every time. I've looked into it and found out about a new Java 8 feature called DocLint which blames our JavaDoc comments of being incomplete. So i switched this feature off so far:
-Xdoclint:nonein a second commit (db98ee8). Also this commit updates 'android-maven-plugin' in whole RS project and a few more maven plugins.// ------------------------------------------------------------------
About the first one (db98ee8). There was this message printed everywhere in the log:
As for me this massage does not say anything useful at all. And the second thing is the message is printed even when there's nothing in a cache, because of this piece of code:
if (allDeleted || cacheFileList.length == 0) {Ln.d("Some file could not be deleted from cache.");}Here in case there are no files in the cache this message just keeps being printed.
It is fixed in the first commit.
Take a look if it is useful to you.