Treat Bits as OctetString (prometheus#870)

Signed-off-by: Sébastien Coavoux <[email protected]> Signed-off-by: Stephan Windischmann <[email protected]>
stephan-windischmann-sky · Oct 27, 2023 · 5a181b7 · 5a181b7
1 parent 367b490
commit 5a181b7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/collector/collector.go b/collector/collector.go
@@ -725,7 +725,7 @@ func pduValueAsString(pdu *gosnmp.SnmpPDU, typ string) string {
 		// DisplayString.
 		return pdu.Value.(string)
 	case []byte:
-		if typ == "" {
+		if typ == "" || typ == "Bits" {
 			typ = "OctetString"
 		}
 		// Reuse the OID index parsing code.

diff --git a/collector/collector_test.go b/collector/collector_test.go
@@ -701,6 +701,11 @@ func TestPduValueAsString(t *testing.T) {
 			typ:    "InetAddressIPv6",
 			result: "0102:0304:0506:0708:090A:0B0C:0D0E:0F10",
 		},
+		{
+			pdu:    &gosnmp.SnmpPDU{Value: []byte{2, 0}},
+			typ:    "Bits",
+			result: "0x0200",
+		},
 		{
 			pdu:    &gosnmp.SnmpPDU{Value: nil},
 			result: "",