[sflow_test.py]: tests for config sflow commands. (sonic-net#1112)

* [sflow_test.py]: tests for config sflow commands. Changes: -- show sflow use ctx.obj['db'] instead of creating new instance, this is must for test, else config change will not be reflected. -- config SFLOW tests for config sflow <enable|disable> config sflow agent-id <add | del> config sflow collector add|del config sflow interface <enable|disable> config sflow interface sample-rate Signed-off-by: Praveen Chaudhary <[email protected]>
stepanblyschak · Sep 30, 2020 · 2cd7893 · 2cd7893
1 parent adb8941
commit 2cd7893
Show file tree

Hide file tree

Showing 3 changed files with 213 additions and 8 deletions.
diff --git a/show/main.py b/show/main.py
@@ -1592,11 +1592,11 @@ def policer(policer_name, verbose):
 # 'sflow command ("show sflow ...")
 #
 @cli.group(invoke_without_command=True)
+@clicommon.pass_db
 @click.pass_context
-def sflow(ctx):
+def sflow(ctx, db):
     """Show sFlow related information"""
     if ctx.invoked_subcommand is None:
-        db = Db()
         show_sflow_global(db.cfgdb)
 
 #

diff --git a/tests/mock_tables/config_db.json b/tests/mock_tables/config_db.json
@@ -1,7 +1,6 @@
 {
     "SFLOW|global": {
         "admin_state": "up",
-        "agent_id": "eth0",
         "polling_interval": "0"
     },
     "SFLOW_COLLECTOR|prod": {

diff --git a/tests/sflow_test.py b/tests/sflow_test.py
@@ -1,19 +1,23 @@
 import os
 import sys
 import pytest
+import mock
+
 from click.testing import CliRunner
 from utilities_common.db import Db
 
 import show.main as show
-import mock_tables.dbconnector
+import config.main as config
+
+config.asic_type = mock.MagicMock(return_value = "broadcom")
 
 # Expected output for 'show sflow'
 show_sflow_output = ''+ \
 """
 sFlow Global Information:
   sFlow Admin State:          up
   sFlow Polling Interval:     0
-  sFlow AgentID:              eth0
+  sFlow AgentID:              default
 
   2 Collectors configured:
     Name: prod                IP addr: fe80::6e82:6aff:fe1e:cd8e UDP port: 6343
@@ -46,17 +50,219 @@ def setup_class(cls):
     def test_show_sflow(self):
         runner = CliRunner()
         result = runner.invoke(show.cli.commands["sflow"], [], obj=Db())
-        print(sys.stderr, result.output)
+        print(result.exit_code, result.output)
         assert result.exit_code == 0
         assert result.output == show_sflow_output
 
     def test_show_sflow_intf(self):
         runner = CliRunner()
-        result = runner.invoke(show.cli.commands["sflow"].commands["interface"], [], obj=Db())
-        print(sys.stderr, result.output)
+        result = runner.invoke(show.cli.commands["sflow"].commands["interface"], \
+            [], obj=Db())
+        print(result.exit_code, result.output)
         assert result.exit_code == 0
         assert result.output == show_sflow_intf_output
 
+    def test_config_sflow_disable_enable(self):
+        # config sflow <enable|disable>
+        db = Db()
+        runner = CliRunner()
+        obj = {'db':db.cfgdb}
+
+        #disable
+        result = runner.invoke(config.config.commands["sflow"].\
+            commands["disable"], [], obj=obj)
+        print(result.exit_code, result.output)
+        assert result.exit_code == 0
+
+        # change the output
+        global show_sflow_output
+        show_sflow_output_local = show_sflow_output.replace(\
+            'Admin State:          up', \
+            'Admin State:          down')
+
+        # run show and check
+        result = runner.invoke(show.cli.commands["sflow"], [], obj=db)
+        print(result.exit_code, result.output, show_sflow_output_local)
+        assert result.exit_code == 0
+        assert result.output == show_sflow_output_local
+
+        #enable
+        result = runner.invoke(config.config.commands["sflow"].\
+            commands["enable"], [], obj=obj)
+        print(result.exit_code, result.output)
+        assert result.exit_code == 0
+
+        # run show and check
+        result = runner.invoke(show.cli.commands["sflow"], [], obj=db)
+        print(result.exit_code, result.output)
+        assert result.exit_code == 0
+        assert result.output == show_sflow_output
+
+        return
+
+    def test_config_sflow_agent_id(self):
+        db = Db()
+        runner = CliRunner()
+        obj = {'db':db.cfgdb}
+
+        # mock netifaces.interface
+        config.netifaces.interfaces = mock.MagicMock(return_value = "Ethernet0")
+
+        # set agent-id
+        result = runner.invoke(config.config.commands["sflow"].\
+            commands["agent-id"].commands["add"], ["Ethernet0"], obj=obj)
+        print(result.exit_code, result.output)
+        assert result.exit_code == 0
+
+        # change the output
+        global show_sflow_output
+        show_sflow_output_local = \
+            show_sflow_output.replace('default', 'Ethernet0')
+
+        # run show and check
+        result = runner.invoke(show.cli.commands["sflow"], [], obj=db)
+        print(result.exit_code, result.output, show_sflow_output_local)
+        assert result.exit_code == 0
+        assert result.output == show_sflow_output_local
+
+        #del agent id
+        result = runner.invoke(config.config.commands["sflow"].\
+            commands["agent-id"].commands["del"], [], obj=obj)
+        print(result.exit_code, result.output)
+        assert result.exit_code == 0
+
+        # run show and check
+        result = runner.invoke(show.cli.commands["sflow"], [], obj=db)
+        print(result.exit_code, result.output)
+        assert result.exit_code == 0
+        assert result.output == show_sflow_output
+
+        return
+
+    def test_config_sflow_collector(self):
+        db = Db()
+        runner = CliRunner()
+        obj = {'db':db.cfgdb}
+
+        # del a collector
+        result = runner.invoke(config.config.commands["sflow"].\
+            commands["collector"].commands["del"], ["prod"], obj=obj)
+        print(result.exit_code, result.output)
+        assert result.exit_code == 0
+
+        # change the output
+        global show_sflow_output
+        show_sflow_output_local = show_sflow_output.replace(\
+    "2 Collectors configured:\n\
+    Name: prod                IP addr: fe80::6e82:6aff:fe1e:cd8e UDP port: 6343\n\
+    Name: ser5                IP addr: 172.21.35.15    UDP port: 6343", \
+    "1 Collectors configured:\n\
+    Name: ser5                IP addr: 172.21.35.15    UDP port: 6343")
+
+        # run show and check
+        result = runner.invoke(show.cli.commands["sflow"], [], obj=db)
+        print(result.exit_code, result.output, show_sflow_output_local)
+        assert result.exit_code == 0
+        assert result.output == show_sflow_output_local
+
+        # add collector
+        result = runner.invoke(config.config.commands["sflow"].\
+            commands["collector"].commands["add"], \
+            ["prod", "fe80::6e82:6aff:fe1e:cd8e"], obj=obj)
+        assert result.exit_code == 0
+
+        # run show and check
+        result = runner.invoke(show.cli.commands["sflow"], [], obj=db)
+        print(result.exit_code, result.output)
+        assert result.exit_code == 0
+        assert result.output == show_sflow_output
+
+        return
+
+    def test_config_sflow_polling_interval(self):
+        db = Db()
+        runner = CliRunner()
+        obj = {'db':db.cfgdb}
+
+        # set to 20
+        result = runner.invoke(config.config.commands["sflow"].\
+            commands["polling-interval"], ["20"], obj=obj)
+        print(result.exit_code, result.output)
+        assert result.exit_code == 0
+
+        # change the expected output
+        global show_sflow_output
+        show_sflow_output_local = show_sflow_output.replace(\
+            'sFlow Polling Interval:     0', \
+            'sFlow Polling Interval:     20')
+
+        # run show and check
+        result = runner.invoke(show.cli.commands["sflow"], [], obj=db)
+        print(result.exit_code, result.output)
+        assert result.exit_code == 0
+        assert result.output == show_sflow_output_local
+
+        #reset to 0, no need to verify this one
+        result = runner.invoke(config.config.commands["sflow"].\
+            commands["polling-interval"], ["0"], obj=obj)
+        print(result.exit_code, result.output)
+        assert result.exit_code == 0
+
+        return
+
+    def test_config_sflow_intf_enable_disable(self):
+        db = Db()
+        runner = CliRunner()
+        obj = {'db':db.cfgdb}
+
+        # mock interface_name_is_valid
+        config.interface_name_is_valid = mock.MagicMock(return_value = True)
+
+        # intf enable
+        result = runner.invoke(config.config.commands["sflow"].\
+            commands["interface"].commands["enable"], ["Ethernet1"], obj=obj)
+        print(result.exit_code, result.output)
+        assert result.exit_code == 0
+
+        # we can not use 'show sflow interface', becasue 'show sflow interface'
+        # gets data from appDB, we need to fetch data from configDB for verification
+        sflowSession = db.cfgdb.get_table('SFLOW_SESSION')
+        assert sflowSession["Ethernet1"]["admin_state"] == "up"
+
+        # intf disable
+        result = runner.invoke(config.config.commands["sflow"].\
+            commands["interface"].commands["disable"], ["Ethernet1"], obj=obj)
+        print(result.exit_code, result.output)
+        assert result.exit_code == 0
+
+        # verify in configDb
+        sflowSession = db.cfgdb.get_table('SFLOW_SESSION')
+        assert sflowSession["Ethernet1"]["admin_state"] == "down"
+
+        return
+
+    def test_config_sflow_intf_sample_rate(self):
+        db = Db()
+        runner = CliRunner()
+        obj = {'db':db.cfgdb}
+
+        # mock interface_name_is_valid
+        config.interface_name_is_valid = mock.MagicMock(return_value = True)
+
+        # set sample-rate to 2500
+        result = runner.invoke(config.config.commands["sflow"].\
+            commands["interface"].commands["sample-rate"], \
+            ["Ethernet2", "2500"], obj=obj)
+        print(result.exit_code, result.output)
+        assert result.exit_code == 0
+
+        # we can not use 'show sflow interface', becasue 'show sflow interface'
+        # gets data from appDB, we need to fetch data from configDB for verification
+        sflowSession = db.cfgdb.get_table('SFLOW_SESSION')
+        assert sflowSession["Ethernet2"]["sample_rate"] == "2500"
+
+        return
+
     @classmethod
     def teardown_class(cls):
         print("TEARDOWN")