Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lexer range calculation for tokens #252

Merged
merged 2 commits into from
Sep 26, 2018
Merged

Fix lexer range calculation for tokens #252

merged 2 commits into from
Sep 26, 2018

Conversation

djbe
Copy link
Contributor

@djbe djbe commented Sep 26, 2018

There's a bug where tokens without spaces such as {{Test}} are being parsed as Tes.

This PR fixes that issue, and adds a test to ensure this doesn't happen again.

@djbe djbe added the bug label Sep 26, 2018
@djbe djbe merged commit 7417332 into master Sep 26, 2018
@djbe djbe deleted the fix/lexer-range branch September 26, 2018 01:18
@yonaskolb
Copy link
Collaborator

Was that a regression? Do we need a hotfix?

@djbe
Copy link
Contributor Author

djbe commented Sep 26, 2018

This was a regression, yes. Unfortunately our tests didn't catch this before the 0.13 release.I've already made a 0.13.1 release, so no worries.

I meant to do a release PR, but I accidentally pushed on master and we're not allowed to rebase, so 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants