-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Spectre 0.9.0 #247
Conversation
9cc4e92
to
55f22bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ideal, as PathKit has also updated to Spectre 0.9.
Still needs a changelog entry.
@djbe as you are on setting up swiftlint for this project, maybe you can add danger too for this kind of stuff? I also wonder if there is a plugin for checking a spelling in doc comments... |
I can take a look at it, although we haven't even set it up for SwiftGen yet. @AliSoftware started with it quite a while ago with SwiftGen/templates#12, but we haven't taken the time yet to finish things up. But first let's add SwiftLint, and continue from there. |
I'd totally love to add a Danger bot for those kind of things! Just never found the time (you know, real life and not enough free time and all). I don't really like that for now we have to remind that every time in person and block PRs for that (to avoid accidentally merging them without the CHANGELOG), as it might feel quite harsh even if necessary, so a Danger bot would make things way better indeed! Would love a PR for that ; unfortunately I haven't found a CHANGELOG plugin which matches our CHANGELOG specific style but at least we could warn if it hasn't changed at all at first, and refine that later to also check that the format (esp. fill stop then two spaces) is right, which is the main thing missing from existing Danger plugins. |
It has some improvements to Xcode integration. Also used
swift test --generate-linuxmain
. AndPackage.resolved
is not ignored anymore to ensure dependencies are always in sync.