Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed resolving variable as string literal #168

Merged
merged 1 commit into from
Dec 27, 2017
Merged

Conversation

ilyapuchka
Copy link
Collaborator

Resolves #159

For some reason in unit tests Variable.resolve method returns String in this case
but in the app on iOS simulator it results in Swift.Substring (which is actually expected)
and then check for String type in EqualityExpression fails.

For some reason in unit tests resolve method returns String in this case
but in the app on iOS simulator it results in Swift.Substring (which is actually expected)
and then check for String type fails
@ilyapuchka ilyapuchka requested a review from kylef December 26, 2017 22:17
@kylef kylef merged commit 0f3a302 into master Dec 27, 2017
@kylef kylef deleted the fix-string-comparison branch December 27, 2017 04:27
ilyapuchka added a commit that referenced this pull request Dec 28, 2017
In Swift 4, a Substring was returned.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

String equality/inequality comparisons not working
2 participants