Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(JATS): Decoding tag table-wrap-foot for table #674

Merged
merged 3 commits into from
Sep 9, 2020

Conversation

nokome
Copy link
Member

@nokome nokome commented Sep 8, 2020

This is a copy of #667 created as a branch in this repo so we can all better collaborate on it.

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2020

Codecov Report

Merging #674 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #674      +/-   ##
==========================================
+ Coverage   84.78%   84.81%   +0.02%     
==========================================
  Files          83       83              
  Lines        6954     6967      +13     
  Branches     2076     2081       +5     
==========================================
+ Hits         5896     5909      +13     
  Misses       1035     1035              
  Partials       23       23              
Impacted Files Coverage Δ
src/codecs/jats/index.ts 95.34% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a754156...12b8ec7. Read the comment docs.

@nokome nokome force-pushed the 667-decoding-tag-table-wrap-foot branch from ce5b4d1 to bd0ec61 Compare September 9, 2020 04:48
@nokome
Copy link
Member Author

nokome commented Sep 9, 2020

Hi @asisiuc. I have made some changes to make the table description an array of block content nodes. I think this will be more useful when decoding to HTML, or other formats.

I will merge this now. Please feel free to submit another PR, if this structure does not meet your needs.

@nokome nokome merged commit 33219e5 into master Sep 9, 2020
@nokome nokome deleted the 667-decoding-tag-table-wrap-foot branch September 9, 2020 05:58
@stencila-ci
Copy link
Collaborator

🎉 This PR is included in version 0.99.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants