-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase unit test coverage #67
Conversation
great @william-hutchison . take also example (you could even copy as is) the pull request to tidySingleCell3xperiment for the unit test improvement. |
Great, the new unit tests in tidySingleCellExperiment will be very helpful. I will work on adding more tests, removing hard coded numbers and swapping out the magrittr pipe. |
I added more tests, bringing coverage up to 88.12%. I also made some superficial changes to the style and replaced the magrittr pipe with the base pipe. Replacing all hard coded numbers will be a reasonably large task, which I am happy to do, but might not be the top priority right now. |
Actually, maybe I will go ahead and start replacing hard coded numbers. It would be nice to tick the task off the open challenges list. Sorry for requesting a review too early! |
I have removed hard coded numbers from the tidyseurat unit tests. Combined, I think the changes within this pull request bring testing across tidyseurat to a reasonable level. |
Well done! |
I created additional unit tests for the dplyr, tidyr and pillar adapters, and the
get_abundance
utilities.This brings tidyseurat test coverage to 78.64%, as calculated by dev_tools::test_coverage(). This still seems a bit low, but the remaining untested code does not seem amenable to testing. For example, plotting functions.