Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase unit test coverage #67

Merged
merged 14 commits into from
Aug 8, 2023
Merged

Increase unit test coverage #67

merged 14 commits into from
Aug 8, 2023

Conversation

william-hutchison
Copy link
Collaborator

I created additional unit tests for the dplyr, tidyr and pillar adapters, and the get_abundance utilities.

This brings tidyseurat test coverage to 78.64%, as calculated by dev_tools::test_coverage(). This still seems a bit low, but the remaining untested code does not seem amenable to testing. For example, plotting functions.

@william-hutchison william-hutchison marked this pull request as draft August 7, 2023 02:41
@stemangiola
Copy link
Owner

great @william-hutchison . take also example (you could even copy as is) the pull request to tidySingleCell3xperiment for the unit test improvement.

@william-hutchison
Copy link
Collaborator Author

Great, the new unit tests in tidySingleCellExperiment will be very helpful. I will work on adding more tests, removing hard coded numbers and swapping out the magrittr pipe.

@william-hutchison
Copy link
Collaborator Author

I added more tests, bringing coverage up to 88.12%. I also made some superficial changes to the style and replaced the magrittr pipe with the base pipe.

Replacing all hard coded numbers will be a reasonably large task, which I am happy to do, but might not be the top priority right now.

@william-hutchison william-hutchison marked this pull request as ready for review August 7, 2023 06:06
@william-hutchison william-hutchison marked this pull request as draft August 7, 2023 06:12
@william-hutchison
Copy link
Collaborator Author

Actually, maybe I will go ahead and start replacing hard coded numbers. It would be nice to tick the task off the open challenges list. Sorry for requesting a review too early!

@william-hutchison
Copy link
Collaborator Author

I have removed hard coded numbers from the tidyseurat unit tests. Combined, I think the changes within this pull request bring testing across tidyseurat to a reasonable level.

@william-hutchison william-hutchison marked this pull request as ready for review August 8, 2023 05:43
@stemangiola stemangiola linked an issue Aug 8, 2023 that may be closed by this pull request
@stemangiola
Copy link
Owner

I have removed hard coded numbers from the tidyseurat unit tests. Combined, I think the changes within this pull request bring testing across tidyseurat to a reasonable level.

Well done!

@stemangiola stemangiola merged commit 8daf535 into stemangiola:master Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve unit testing of tidyseurat
2 participants