Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #167

Merged
merged 26 commits into from
Apr 15, 2021
Merged

Dev #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
ef58475
drop comment
stemangiola Mar 21, 2021
5904542
fix overrepresentation for SE
stemangiola Mar 22, 2021
01e7804
allow external TMM scaling, used internally for heterogeneity single …
stemangiola Apr 6, 2021
338a4b8
revert back the old plotMDS strategy
stemangiola Apr 7, 2021
cc95fd4
fix SE functions
stemangiola Apr 7, 2021
07aac3b
fix for old version
stemangiola Apr 7, 2021
b4a6f27
fix scaling for PCA
stemangiola Apr 12, 2021
5c3622b
fix gene enrichment validation
stemangiola Apr 12, 2021
c621416
Merge pull request #165 from stemangiola/hotfix-plotMDS
stemangiola Apr 12, 2021
72fd8a7
Merge pull request #164 from stemangiola/allow-external-TMM
stemangiola Apr 12, 2021
64fee8b
Update actions to R 4.1 and Bioc 3.13
mblue9 Apr 12, 2021
59e4401
Install Seurat from souror MAc
mblue9 Apr 12, 2021
62b4b61
Fix
mblue9 Apr 12, 2021
6a41cde
fix reduce dimensions for MDS and tSNE with scale argument from PCA
stemangiola Apr 13, 2021
58fd7bd
fix tests
stemangiola Apr 13, 2021
70aa84a
add LazyDataCompression
stemangiola Apr 13, 2021
f777e8a
fix vignette issue
stemangiola Apr 13, 2021
d5e3402
fix left_join
stemangiola Apr 13, 2021
b0deaff
update lifecycle
stemangiola Apr 14, 2021
2651b55
update tests
stemangiola Apr 14, 2021
04515dd
fix tests
stemangiola Apr 14, 2021
91c76f3
update loading message
stemangiola Apr 14, 2021
e8e9684
fix tests and vignette
stemangiola Apr 14, 2021
0b75189
fix CHECK
stemangiola Apr 15, 2021
69f2494
fix dependencies
stemangiola Apr 15, 2021
c55029c
Remove mention of github due to error
mblue9 Apr 15, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 28 additions & 11 deletions .github/workflows/check-bioc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ env:
run_pkgdown: 'true'
has_RUnit: 'false'
cache-version: 'cache-v1'
run_docker: 'false'

jobs:
build-check:
Expand All @@ -51,9 +52,9 @@ jobs:
fail-fast: false
matrix:
config:
- { os: ubuntu-latest, r: '4.0', bioc: '3.12', cont: "bioconductor/bioconductor_docker:RELEASE_3_12", rspm: "https://packagemanager.rstudio.com/cran/__linux__/focal/latest" }
- { os: macOS-latest, r: '4.0', bioc: '3.12'}
- { os: windows-latest, r: '4.0', bioc: '3.12'}
- { os: ubuntu-latest, r: 'devel', bioc: '3.13', cont: "bioconductor/bioconductor_docker:devel", rspm: "https://packagemanager.rstudio.com/cran/__linux__/focal/latest" }
- { os: macOS-latest, r: 'devel', bioc: '3.13'}
- { os: windows-latest, r: 'devel', bioc: '3.13'}
env:
R_REMOTES_NO_ERRORS_FROM_WARNINGS: true
RSPM: ${{ matrix.config.rspm }}
Expand Down Expand Up @@ -101,16 +102,16 @@ jobs:
uses: actions/cache@v2
with:
path: ${{ env.R_LIBS_USER }}
key: ${{ env.cache-version }}-${{ runner.os }}-biocversion-RELEASE_3_12-r-4.0-${{ hashFiles('.github/depends.Rds') }}
restore-keys: ${{ env.cache-version }}-${{ runner.os }}-biocversion-RELEASE_3_12-r-4.0-
key: ${{ env.cache-version }}-${{ runner.os }}-biocversion-devel-r-devel-${{ hashFiles('.github/depends.Rds') }}
restore-keys: ${{ env.cache-version }}-${{ runner.os }}-biocversion-devel-r-devel-

- name: Cache R packages on Linux
if: "!contains(github.event.head_commit.message, '/nocache') && runner.os == 'Linux' "
uses: actions/cache@v2
with:
path: /home/runner/work/_temp/Library
key: ${{ env.cache-version }}-${{ runner.os }}-biocversion-RELEASE_3_12-r-4.0-${{ hashFiles('.github/depends.Rds') }}
restore-keys: ${{ env.cache-version }}-${{ runner.os }}-biocversion-RELEASE_3_12-r-4.0-
key: ${{ env.cache-version }}-${{ runner.os }}-biocversion-devel-r-devel-${{ hashFiles('.github/depends.Rds') }}
restore-keys: ${{ env.cache-version }}-${{ runner.os }}-biocversion-devel-r-devel-

- name: Install Linux system dependencies
if: runner.os == 'Linux'
Expand Down Expand Up @@ -156,6 +157,13 @@ jobs:
run: |
BiocManager::install(version = "${{ matrix.config.bioc }}", ask = FALSE)
shell: Rscript {0}

## 12th April 2021 No Seurat binary available for Mac currently so install from source
- name: Install Seurat for macOS-latest
if: matrix.config.os == 'macOS-latest'
run: |
BiocManager::install("Seurat", type="source")
shell: Rscript {0}

- name: Install dependencies pass 1
run: |
Expand All @@ -180,7 +188,7 @@ jobs:
## Pass #2 at installing dependencies
message(paste('****', Sys.time(), 'pass number 2 at installing dependencies: any remaining dependencies ****'))
remotes::install_local(dependencies = TRUE, repos = BiocManager::repositories(), build_vignettes = TRUE, upgrade = TRUE)

## For running the checks
message(paste('****', Sys.time(), 'installing rcmdcheck and BiocCheck ****'))
remotes::install_cran("rcmdcheck")
Expand All @@ -203,7 +211,7 @@ jobs:
- name: Install pkgdown
if: github.ref == 'refs/heads/master' && env.run_pkgdown == 'true' && runner.os == 'Linux'
run: |
remotes::install_cran("pkgdown")
remotes::install_github("r-lib/pkgdown")
shell: Rscript {0}

- name: Session info
Expand Down Expand Up @@ -272,6 +280,15 @@ jobs:
if: failure()
uses: actions/upload-artifact@master
with:
name: ${{ runner.os }}-biocversion-RELEASE_3_12-r-4.0-results
name: ${{ runner.os }}-biocversion-devel-r-devel-results
path: check


- uses: docker/build-push-action@v1
if: "!contains(github.event.head_commit.message, '/nodocker') && env.run_docker == 'true' && runner.os == 'Linux' "
with:
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_PASSWORD }}
repository: stemangiola/tidybulk
tag_with_ref: true
tag_with_sha: true
tags: latest
4 changes: 3 additions & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,8 @@ Suggests:
devtools,
functional,
survminer,
tidySummarizedExperiment
tidySummarizedExperiment,
markdown
VignetteBuilder:
knitr
RdMacros:
Expand All @@ -76,3 +77,4 @@ biocViews: AssayDomain, Infrastructure, RNASeq, DifferentialExpression, GeneExpr
Encoding: UTF-8
LazyData: true
RoxygenNote: 7.1.1
LazyDataCompression: xz
2 changes: 2 additions & 0 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ import(tibble)
import(tidyr)
importFrom(SummarizedExperiment,assays)
importFrom(SummarizedExperiment,colData)
importFrom(SummarizedExperiment,rowData)
importFrom(dplyr,arrange)
importFrom(dplyr,bind_rows)
importFrom(dplyr,distinct)
Expand Down Expand Up @@ -151,6 +152,7 @@ importFrom(stringr,str_replace)
importFrom(stringr,str_replace_all)
importFrom(stringr,str_split)
importFrom(tibble,as_tibble)
importFrom(tibble,enframe)
importFrom(tibble,tibble)
importFrom(tidyr,complete)
importFrom(tidyr,nest)
Expand Down
15 changes: 0 additions & 15 deletions R/data.R
Original file line number Diff line number Diff line change
@@ -1,13 +1,3 @@
#' Example data set
#'
#'
"counts"

#' Example data set reduced
#'
#'
"counts_mini"

#' Cibersort reference
#'
#'
Expand All @@ -23,11 +13,6 @@
#'
"ensembl_symbol_mapping"

#' Data set
#'
#'
"breast_tcga_mini"

#' flybaseIDs
#'
#'
Expand Down
18 changes: 9 additions & 9 deletions R/dplyr_methods.R
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ bind_cols.tidybulk <- function(..., .id = NULL)
#'
#' @examples
#'
#' distinct(tidybulk::counts_mini)
#' tidybulk::se_mini %>% tidybulk() %>% distinct()
#'
#'
#' @export
Expand Down Expand Up @@ -723,8 +723,8 @@ rowwise.tidybulk <- function(data, ...)
#'
#' @examples
#'`%>%` = magrittr::`%>%`
#' annotation = tidybulk::counts %>% distinct(sample) %>% mutate(source = "AU")
#' tidybulk::counts %>% left_join(annotation)
#' annotation = tidybulk::counts_SE %>% tidybulk() %>% as_tibble() %>% distinct(sample) %>% mutate(source = "AU")
#' tidybulk::counts_SE %>% tidybulk() %>% as_tibble() %>% left_join(annotation)
#'
#' @rdname dplyr-methods
#' @name left_join
Expand Down Expand Up @@ -763,8 +763,8 @@ left_join.tidybulk <- function (x, y, by = NULL, copy = FALSE, suffix = c(".x",
#'
#' @examples
#'`%>%` = magrittr::`%>%`
#' annotation = tidybulk::counts %>% distinct(sample) %>% mutate(source = "AU")
#' tidybulk::counts %>% inner_join(annotation)
#' annotation = tidybulk::counts_SE %>% tidybulk() %>% as_tibble() %>% distinct(sample) %>% mutate(source = "AU")
#' tidybulk::counts_SE %>% tidybulk() %>% as_tibble() %>% inner_join(annotation)
#'
#' @rdname join-methods
#' @name inner_join
Expand Down Expand Up @@ -802,8 +802,8 @@ inner_join.tidybulk <- function (x, y, by = NULL, copy = FALSE, suffix = c(".x",
#'
#' @examples
#'`%>%` = magrittr::`%>%`
#' annotation = tidybulk::counts %>% distinct(sample) %>% mutate(source = "AU")
#' tidybulk::counts %>% right_join(annotation)
#' annotation = tidybulk::counts_SE %>% tidybulk() %>% as_tibble() %>% distinct(sample) %>% mutate(source = "AU")
#' tidybulk::counts_SE %>% tidybulk() %>% as_tibble() %>% right_join(annotation)
#'
#' @rdname join-methods
#' @name right_join
Expand Down Expand Up @@ -843,8 +843,8 @@ right_join.tidybulk <- function (x, y, by = NULL, copy = FALSE, suffix = c(".x",
#'
#' @examples
#'`%>%` = magrittr::`%>%`
#' annotation = tidybulk::counts %>% distinct(sample) %>% mutate(source = "AU")
#' tidybulk::counts %>% full_join(annotation)
#' annotation = tidybulk::counts_SE %>% tidybulk() %>% as_tibble() %>% distinct(sample) %>% mutate(source = "AU")
#' tidybulk::counts_SE %>% tidybulk() %>% as_tibble() %>% full_join(annotation)
#'
#' @rdname join-methods
#' @name full_join
Expand Down
Loading