refactoring: format all code #56

[vraybaud]

• Import orders are now compliant with the Ktlint Intellij Settings. If you do ktlint, you'll find out "Imports must be ordered in lexicographic order without any empty lines in-between" errors, there are a known issue of ktlint <= 0.36.0 : Alphabetical import ordering enabled by default is a problem in Android Studio/IntelliJ pinterest/ktlint#527 which is fixed in v0.37.0, which requires an update from org.jlleitschuh.gradle.ktlint plugin.

• Indentations are ajusted, removing useless indentations that were in many files.

• Hard wrapping at 120 characters to ease the code review.

• Add new line at end of file (see POSIX definition of a line)

Please if you see something strange, do comment it. (I could have missed something)

[github-actions]

CLA Assistant Lite All Contributors have signed the CLA.

[HoucemKacem]

indentation seems to be not good here (and below).

[vraybaud]

This is to clearly identify the continuation of the expression, so you clearly see at first sight that this is all a single expression.

Maybe in this case it seems useless, but you could have cases like that :

val a = it.size == 1 &&
it[0].second.subscriptionId == subscription.id &&
it[0].second.data.size == 1 &&
it[0].third
a

There it becomes more relevant to have this indent to more easily detect the what is variable a and what is returned.

[HoucemKacem]

Do we need to configure something in Intellij ?
From now on how can we check the code style ?

[vraybaud]

Indeed I'll share a common settings file to import for Intellij IDEA users to properly make changes without braking the format of every files. (tbd where in the project)

[bobeal]

I find weird this extra indent. I guess it is considered like a continuation indent but ...

[bobeal]

I would be more comfortable with something like:

values
    .map {
    }
    .filter {
    }

[bobeal]

Rather than

values.map {
}
    .filter {
    }

[vraybaud]

I don't think continuation indent applies to braces...

I think expected result is :

values.filterValues {
    it[0] is Map<*, *>
}.mapValues {
    expandValueAsMap(it.value)
}.filter {
    !(NGSILD_PROPERTIES_CORE_MEMBERS.plus(NGSILD_RELATIONSHIPS_CORE_MEMBERS)).contains(it.key) &&
        isAttributeOfType(it.value, NGSILD_PROPERTY_TYPE)
}.forEach { entry ->
    if (!neo4jRepository.hasPropertyOfName(subject.id, entry.key))
        throw BadRequestDataException("Property ${entry.key.extractShortTypeFromExpanded()} does not exist")
    updatePropertyValues(subject.id, entry.key, entry.value)
}

But there were a newline placed in first line..
What do you think ?

[bobeal]

I'm fine with your expected result!

[vraybaud]

Fixed in d6d00ee

[bobeal]

Indeed I'll share a common settings file to import for Intellij IDEA users to properly make changes without braking the format of every files. (tbd where in the project)

Add this in the PR (with instructions in the README)

[vraybaud]

Indeed I'll share a common settings file to import for Intellij IDEA users to properly make changes without braking the format of every files. (tbd where in the project)

Add this in the PR (with instructions in the README)

I will add instructions in the README for this PR but we should do an issue (not priority) to create a CONTRIBUTING.md

[bobeal]

Indeed I'll share a common settings file to import for Intellij IDEA users to properly make changes without braking the format of every files. (tbd where in the project)

Add this in the PR (with instructions in the README)

I will add instructions in the README for this PR but we should do an issue (not priority) to create a CONTRIBUTING.md

Yep, create the issue.