Refacto csr logic to context source caller

[thomasBousselin]

No description provided.

[github-actions]

Test Results

   70 files  ±0     70 suites  ±0   1m 24s ⏱️ -2s
1 140 tests +2  1 140 ✅ +2  0 💤 ±0  0 ❌ ±0 
1 179 runs  +2  1 179 ✅ +2  0 💤 ±0  0 ❌ ±0 

Results for commit 3ba9204. ± Comparison against base commit a6b8b37.

This pull request removes 193 and adds 41 tests. Note that renamed tests count towards both.

                           …, withTemporalValues=true, withAudit=false, expectation={
                      "@id": "https://uri…
                      "@type": "@json",
                      …
                    "@value": "/A/B"
                    "@value": "/C/D"
                    "@value": 20
                    "…
                    {
                  "@type": "https://uri.etsi.org/ngsi-ld/DateTime",
…

com.egm.stellio.search.csr.service.ContextSourceCallerTests ‑ queryEntities ContextSource should return a RevalidationFailedWarning when receiving bad payload()
com.egm.stellio.search.csr.service.ContextSourceCallerTests ‑ queryEntitiesFromAllSources should return the warnings sent by the CSRs and update the statuses()
com.egm.stellio.search.csr.service.ContextSourceCallerTests ‑ queryEntitiesFromContextSource should return the count and the entities when the request succeed()
com.egm.stellio.search.csr.service.ContextSourceCallerTests ‑ retrieveEntityContextSource should return a RevalidationFailedWarning when receiving bad payload()
com.egm.stellio.search.csr.service.ContextSourceCallerTests ‑ retrieveEntityFromAllSources should return the warnings sent by the CSRs and update the statuses()
com.egm.stellio.search.csr.service.ContextSourceCallerTests ‑ retrieveEntityFromContextSource should return the entity when the request succeeds()
com.egm.stellio.search.entity.util.PatchAttributeTests ‑ [1] source={
    "attribute": {
        "type": "Property",
        "value": 12.0,
        "observedAt": "2024-04-14T12:34:56Z"
    }
}, target={
    "attribute": {
        "type": "Property",
        "value": 12.2,
        "unitCode": "GRM"
    }
}, expected={
    "attribute": {
        "type": "Property",
        "value": 12.2,
        "unitCode": "GRM",
        "observedAt": "2024-04-14T12:34:56Z"
    }
}
com.egm.stellio.search.entity.util.PatchAttributeTests ‑ [1] source={
    "attribute": {
        "type": "Property",
        "value": 12.0,
        "observedAt": "2024-04-14T12:34:56Z",
        "subAttribute": {
            "type": "Property",
            "value": "subAttribute"
        }
    }
}, target={
    "attribute": {
        "type": "Property",
        "value": 12.2,
        "unitCode": "GRM",
        "subAttribute": {
            "type": "Property",
            "value": "newSubAttributeValue"
        }
    }
}, expected={
    "attribute": {
        "type": "Property",
        "value": 12.2,
        "unitCode": "GRM",
        "observedAt": "2024-04-14T12:34:56Z",
        "subAttribute": {
            "type": "Property",
            "value": "newSubAttributeValue"
        }
    }
}
com.egm.stellio.search.entity.util.PatchAttributeTests ‑ [2] source={
    "attribute": {
        "type": "Property",
        "value": { "en": "car", "fr": "voiture" }
    }
}, target={
    "attribute": {
        "type": "Property",
        "value": { "fr": "vélo", "es": "bicicleta" }
    }
}, expected={
    "attribute": {
        "type": "Property",
        "value": { "en": "car", "fr": "vélo", "es": "bicicleta" }
    }
}
com.egm.stellio.search.entity.util.PatchAttributeTests ‑ [2] source={
    "incoming": {
        "type": "JsonProperty",
        "json": { "id": 1, "b": null, "c": 12.4 },
        "observedAt": "2022-12-24T14:01:22.066Z",
        "subAttribute": {
            "type": "Property",
            "value": "subAttribute"
        }
    }
}, target={
    "incoming": {
        "type": "JsonProperty",
        "json": { "id": 2, "b": "something" },
        "observedAt": "2023-12-24T14:01:22.066Z"
    }
}, expected={
    "incoming": {
        "type": "JsonProperty",
        "json": { "id": 2, "b": "something" },
        "observedAt": "2023-12-24T14:01:22.066Z",
        "subAttribute": {
            "type": "Property",
            "value": "subAttribute"
        }
    }
}
…

♻️ This comment has been updated with latest results.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[bobeal]

please write "refactor", it's only one more letter and it is a real word

[bobeal]

I'd like to keep the convention of suffixing by Service everything that is a service

[bobeal]

It would also be better named something like DistributedOperationService. Or maybe even better DistributedConsumptionOperationService (since having all the dist ops in just one service will not be possible). Even this will end up in 3 services (provision, consumption and subscription) that will quickly be too big. So my final word is DistributedEntityConsumptionOperationService (or DistributedEntityConsumptionService).

[bobeal]

distributeRetrieveEntityOperation?

[bobeal]

distributeQueryEntitiesOperation?

[bobeal]

Suggested change

	fun `queryEntities ContextSource should return a RevalidationFailedWarning when receiving bad payload`() = runTest {
	fun `queryEntitiesFromContextSource should return a RevalidationFailedWarning when receiving bad payload`() = runTest {

[bobeal]

do not forget to update Detekt baseline