Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): do not force existing types to be present in payload when updating or appending types #1115

Merged
merged 4 commits into from
Mar 23, 2024

Conversation

ranim-n
Copy link
Contributor

@ranim-n ranim-n commented Mar 20, 2024

No description provided.

@ranim-n ranim-n added fix Something isn't working core Relates to core API labels Mar 20, 2024
@ranim-n ranim-n self-assigned this Mar 20, 2024
Copy link
Contributor

github-actions bot commented Mar 20, 2024

Test Results

 56 files  + 33   56 suites  +33   1m 28s ⏱️ +52s
926 tests +618  926 ✅ +618  0 💤 ±0  0 ❌ ±0 
965 runs  +657  965 ✅ +657  0 💤 ±0  0 ❌ ±0 

Results for commit 14d4707. ± Comparison against base commit 890b19c.

♻️ This comment has been updated with latest results.

@ranim-n ranim-n force-pushed the fix/add-new-type-to-an-existing-entity branch from 457dec7 to b84691c Compare March 21, 2024 09:44
@bobeal
Copy link
Member

bobeal commented Mar 21, 2024

ready for review? (if so, change the status of the PR)

@ranim-n ranim-n marked this pull request as ready for review March 21, 2024 12:45
@bobeal bobeal linked an issue Mar 21, 2024 that may be closed by this pull request
@bobeal
Copy link
Member

bobeal commented Mar 21, 2024

Set a more meaningful name to the PR (and you can merge after)

Copy link

@bobeal bobeal changed the title fix(core): Add new types to an existing entity fix(core): do not force existing types to be present in payload when updating or appending types Mar 23, 2024
@bobeal bobeal merged commit 9a23d4d into develop Mar 23, 2024
10 checks passed
@bobeal bobeal deleted the fix/add-new-type-to-an-existing-entity branch March 23, 2024 10:53
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core Relates to core API fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relax the rules when updating / appending types to an entity
2 participants