-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependences, register block metadata, & use components, icons, and helpers from repos #618
Open
oakesjosh
wants to merge
34
commits into
master
Choose a base branch
from
update-dependencies-w-package-in-repo
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shouldn't be merged into master yet -- Opening a PR for dev testing, then we can send to support for testing. The we're not tied to a specific release.
This can be a pain to switch back and forth locally. A
rm -rf node_modules
and fresh install is needed. We no longer need the--legacy-peer-deps
when doing an npm install though. Then install the submodulesgit submodule update --init --recursive
. To switch back to a previous branch you'll have to delete the 3 submodule directories.rm -rf src/packages/{components,helpers,icons}
What this does
Replace
dr-kobros/react-webfont-loader
in the KadecnceWebFontLoader and FontLoader components.Replace
react-container-dimensions
with similar function named ContainerDimensions in column-drag-resizer/index,js component.Update
react-select
Update
@wordpress/i18n
Update
@wordpress/scripts
Generally updated dependences
Update the gulp files to not call deprecated functions
Update scss files processed by gulp to use
@use
instead of deprecated@import
.Support new 6.7 block manifest metadata registration
With the updated @wordpress/scripts we can use the new wp-scripts build-blocks-manifest. This is registered in kadence-blocks.php. This improves performance since PHP only has to read and parse a single file from the server to get all block metadata. When attempting the register the blocks later, i'll check if it's already pulled in the metadata before opening the blocks specific block.json.
Moving packages to repos