Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit/KAD-3345 #582

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

audit/KAD-3345 #582

wants to merge 4 commits into from

Conversation

gilbert-hernandez
Copy link
Contributor

@gilbert-hernandez gilbert-hernandez commented Sep 30, 2024

…d to adv text

🎫 #KAD-3345
https://stellarwp.atlassian.net/browse/KAD-3345
...

Issue Info

  • Were you able to reproduce the issue?
  • Is the issue from the ticket solved? (If not, why?)

Checklist

  • I have performed a self-review.
  • No unrelated files are modified.
  • No debugging statements exist (Ex: console.log, error_log).
  • There are no warnings or notices in the wordpress error log.
  • Passes all tests (linting, acceptance, & unit)

Block specific checklist (where relevant)

  • Tested with an existing instance of this block .
  • Tested creating a new instance of this block.
  • Tested with Dynamic content & Elements.

Are there dependent changes in another repository?

  • No.
  • Yes. Please provide the link to the PR.

@gilbert-hernandez
Copy link
Contributor Author

Here is a video of how the feature works now:

textshadowupdates.mp4

Copy link
Contributor

@oakesjosh oakesjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only issue I'm seeing is with existing text shadows not applying on the front end or back end. We'll need to make sure existing values are supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants