KAD-3459 Prevent flashing of design library in Lifter LMS #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It worked for me too, but I am curious why. We’re still putting the button in the same place we were before. so why isn’t lifter just deleting our button like it did before? |
oakesjosh
force-pushed
the
master
branch
2 times, most recently
from
128d4ba
to
cba8757
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the flashing of the icon when editing an Lifter LMS course. Both us and lifter are trying to inject content, using the same method, and are overwriting each others buttons. I tried modifying the selector to make sure we're in the same div, different divs, etc, but switching to a mutation observer seems to be the most reliable way to prevent this from happening. Open to other ideas though
367327015-707f697c-ce77-48cb-b9ed-d949accc61ea.mov