Downcase value when comparing if the source is plural or singular. #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abuiles
commented
Sep 21, 2020
| base = named.name.underscore.classify | ||
| result = plural ? base.pluralize : base | ||
|
|
||
| "#{parent}#{result}" | ||
| end | ||
|
|
||
| def const_name(named) | ||
| # NOTE: classify will strip plurality, so we restore it if necessary | ||
| plural = named.name.pluralize == named.name | ||
| base = named.name.underscore.upcase |
There was a problem hiding this comment.
we don't pluralize base, so this check is actually unnecessary.
2opremio
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While generating protocol 14 XDRs, I noticed a weird output for CAP33 related enums and ops.
The following:
Should have been
After investigating, I found a bug in this library, which was comparing the pluralized version of the name with the original, the problem is that it didn't keep into account the letter casing - leading to incorrect results in scenarios like this one
This PR fixes this issue, making both values down case.