-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update module name to github.com/stellar/throttled #1
Conversation
The builds pass on the latest version of Go but not the myriad of older versions of Go which is understandable. |
There's quite a few things in the build scripts that need updating, but it passes on Go 1.12, and this code is code we're already importing in it's current state, so I think we should merge this even though the other builds are failing, and then discuss how much we want to invest in cleaning up this repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Why isn't the Makefile needed?
Travis knows how to build and test go projects without any configuration. The makefile was causing travis to run |
Summary
Update module name to github.com/stellar/throttled.
Goal and scope
@MonsieurNicolas made the suggestion stellar/go#1642 (comment) that we should take @bartekn's into the @stellar org. He setup the project and I pushed the
master
branch from over there. This change updates the imports and package name internally so that it knows itself at this repo address.Related to stellar/go#1634