Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module name to github.com/stellar/throttled #1

Merged
merged 8 commits into from
Aug 23, 2019
Merged

Update module name to github.com/stellar/throttled #1

merged 8 commits into from
Aug 23, 2019

Conversation

leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented Aug 23, 2019

Summary

Update module name to github.com/stellar/throttled.

Goal and scope

@MonsieurNicolas made the suggestion stellar/go#1642 (comment) that we should take @bartekn's into the @stellar org. He setup the project and I pushed the master branch from over there. This change updates the imports and package name internally so that it knows itself at this repo address.

Related to stellar/go#1634

@leighmcculloch
Copy link
Member Author

The builds pass on the latest version of Go but not the myriad of older versions of Go which is understandable.

@leighmcculloch
Copy link
Member Author

There's quite a few things in the build scripts that need updating, but it passes on Go 1.12, and this code is code we're already importing in it's current state, so I think we should merge this even though the other builds are failing, and then discuss how much we want to invest in cleaning up this repo.

@leighmcculloch leighmcculloch requested review from msfeldstein and bartekn and removed request for MonsieurNicolas August 23, 2019 23:12
@leighmcculloch leighmcculloch mentioned this pull request Aug 23, 2019
@leighmcculloch
Copy link
Member Author

I fixed the TravisCI config in #2. Those changes are temporarily showing up in this diff because I merged the config into this branch to check that the tests pass with these changes. After #2 is merged this PRs diff will be smaller.

Copy link

@tomquisel tomquisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Why isn't the Makefile needed?

@leighmcculloch
Copy link
Member Author

leighmcculloch commented Aug 23, 2019

Travis knows how to build and test go projects without any configuration. The makefile was causing travis to run make install, and the makefile contained unnecessary go get commands. Since we rely on using straight up go commands in our other repos and the makefile contained about 50% things that we don't need, I figured it was better to drop it in our diverged fork than to spend time cleaning it up.

@leighmcculloch leighmcculloch merged commit 89d7581 into stellar:stellar Aug 23, 2019
@leighmcculloch leighmcculloch deleted the stellar branch August 23, 2019 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants