Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename txSOROBAN_RESOURCE_LIMIT_EXCEEDED to more general txSOROBAN_INVALID #143

Merged
merged 2 commits into from
Aug 29, 2023
Merged

rename txSOROBAN_RESOURCE_LIMIT_EXCEEDED to more general txSOROBAN_INVALID #143

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3625ea0
rename txSOROBAN_RESOURCE_LIMIT_EXCEEDED to more general txSOROBAN_IN…
graydon Aug 29, 2023
20d5ce9
Merge branch 'next' into soroban-invalid
graydon Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions Stellar-transaction.x
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1949,14 +1949,12 @@ enum TransactionResultCode
txBAD_AUTH_EXTRA = -10, // unused signatures attached to transaction
txINTERNAL_ERROR = -11, // an unknown error occurred

txNOT_SUPPORTED = -12, // transaction type not supported
txFEE_BUMP_INNER_FAILED = -13, // fee bump inner transaction failed
txBAD_SPONSORSHIP = -14, // sponsorship not confirmed
txBAD_MIN_SEQ_AGE_OR_GAP =
-15, // minSeqAge or minSeqLedgerGap conditions not met
txMALFORMED = -16, // precondition is invalid
// declared Soroban resource usage exceeds the network limit
txSOROBAN_RESOURCE_LIMIT_EXCEEDED = -17
txNOT_SUPPORTED = -12, // transaction type not supported
txFEE_BUMP_INNER_FAILED = -13, // fee bump inner transaction failed
txBAD_SPONSORSHIP = -14, // sponsorship not confirmed
txBAD_MIN_SEQ_AGE_OR_GAP = -15, // minSeqAge or minSeqLedgerGap conditions not met
txMALFORMED = -16, // precondition is invalid
txSOROBAN_INVALID = -17 // soroban-specific preconditions were not met
};

// InnerTransactionResult must be binary compatible with TransactionResult
Expand Down Expand Up @@ -1987,7 +1985,7 @@ struct InnerTransactionResult
case txBAD_SPONSORSHIP:
case txBAD_MIN_SEQ_AGE_OR_GAP:
case txMALFORMED:
case txSOROBAN_RESOURCE_LIMIT_EXCEEDED:
case txSOROBAN_INVALID:
void;
}
result;
Expand Down Expand Up @@ -2034,7 +2032,7 @@ struct TransactionResult
case txBAD_SPONSORSHIP:
case txBAD_MIN_SEQ_AGE_OR_GAP:
case txMALFORMED:
case txSOROBAN_RESOURCE_LIMIT_EXCEEDED:
case txSOROBAN_INVALID:
void;
}
result;
Expand Down