Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker build TAG if supplied #309

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Use docker build TAG if supplied #309

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae9d6f4
Use docker build TAG if supplied
2opremio Oct 4, 2024
ed435e7
Address review feedback
2opremio Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cmd/soroban-rpc/docker/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,14 @@ endif
# Set default value for BINARY_NAME if not provided
BINARY_NAME ?= soroban-rpc

ifndef TAG
# Set the TAG based on the value of BINARY_NAME
ifeq ($(BINARY_NAME),stellar-rpc)
TAG := stellar/stellar-rpc:$(SOROBAN_RPC_VERSION_PACKAGE_VERSION)
else
TAG := stellar/stellar-soroban-rpc:$(SOROBAN_RPC_VERSION_PACKAGE_VERSION)
endif
2opremio marked this conversation as resolved.
Show resolved Hide resolved
endif # TAG


docker-build:
Expand Down
Loading