Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RPC linting #286

Merged
merged 13 commits into from
Sep 10, 2024
Merged

Fix RPC linting #286

merged 13 commits into from
Sep 10, 2024

Conversation

aditya1702
Copy link
Contributor

@aditya1702 aditya1702 commented Sep 6, 2024 •
edited
Loading

What

Fix the linting issues in the following folders:

  • config
  • daemon
  • db
  • feewindow
  • ingest
  • ledgerbucketwindow
  • preflight

Why

The linter has been a harassing us on all our PRs!

Known limitations

NA

@aditya1702 aditya1702 changed the title Fix all linting Fix RPC linting Sep 9, 2024
@aditya1702 aditya1702 marked this pull request as ready for review September 9, 2024 15:36
@aditya1702 aditya1702 requested a review from psheth9 September 9, 2024 18:35
psheth9
psheth9 reviewed Sep 9, 2024
View reviewed changes
Copy link
Contributor

@psheth9 psheth9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👏

left few comments, should be good to go once that's done !!

@aditya1702 aditya1702 merged commit d81c47f into stellar:main Sep 10, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psheth9 psheth9 psheth9 approved these changes

@Shaptic Shaptic Awaiting requested review from Shaptic

@tamirms tamirms Awaiting requested review from tamirms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aditya1702 @psheth9