-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve startup by eliminating unnecessary migration ranges #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditya1702
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one nit comment. Otherwise looks good.
tamirms
reviewed
Aug 30, 2024
tamirms
reviewed
Aug 30, 2024
tamirms
reviewed
Aug 30, 2024
tamirms
reviewed
Aug 30, 2024
@Shaptic the optimization is great! In summary, I have 3 pieces of feedback:
|
Shaptic
force-pushed
the
better-migration-ranges
branch
from
September 4, 2024 18:58
441c60c
to
baced2b
Compare
tamirms
reviewed
Sep 4, 2024
tamirms
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
Shaptic
force-pushed
the
better-migration-ranges
branch
from
September 4, 2024 19:13
baced2b
to
572116a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Speed up startup time in "already migrated" cases by eliminating unnecessary ledger range traversals.
Specifically, this includes the following changes:
LedgerSeqRange
has been refactored to always use a value reference.As a result, if all migrations have occurred, the traversal only occurs over the fee window.
This reduces startup times in a fully-loaded (24hr) database that needs no migrations from ~1m40s to ~1s.
Why
Previously, startup would take a significant amount of time doing nothing because it would loop over a large ledger range and check whether or not a migration was necessary for that ledger. If migrations were already done, it would move on to the next ledger.
In this version, we instead appropriately calculate the ledger range to traverse by only expanding the ledger range if a migration has not already completed.
Known limitations
n/a, tested at length locally