Unify transaction and event retention windows #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a new, `unified history-retention-window` flag and mark the event/transaction window configuration parameters as deprecated. Until we remove the event/transaction flag, `history-retention-window` will be initialized to the maximum of the three.
tamirms
approved these changes
Jun 27, 2024
aditya1702
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Use a new,
unified history-retention-window(with a default value of 1 day until #115 is fixed) flag and mark the event/transaction window configuration parameters as deprecated.Until we remove the event/transaction flag,
history-retention-windowwill be initialized to the maximum of the three.Also, initialize
cfg.HistoryArchiveUserAgentin a more suitable place.Why
Simplifies the configuration. Closes #199
Known limitations
N/A