Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change API field naming style to Camel Case. #164

Closed
wants to merge 1 commit into from
+6 −6
Closed

Change API field naming style to Camel Case. #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cmd/soroban-rpc/internal/methods/get_version_info.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ import (

type GetVersionInfoResponse struct {
Version string `json:"version"`
CommitHash string `json:"commit_hash"`
BuildTimestamp string `json:"build_time_stamp"`
CaptiveCoreVersion string `json:"captive_core_version"`
ProtocolVersion uint32 `json:"protocol_version"`
CommitHash string `json:"commitHash"`
BuildTimestamp string `json:"buildTimestamp"`
CaptiveCoreVersion string `json:"captiveCoreVersion"`
ProtocolVersion uint32 `json:"protocolVersion"`
}

func NewGetVersionInfoHandler(logger *log.Entry, ledgerEntryReader db.LedgerEntryReader, ledgerReader db.LedgerReader, daemon interfaces.Daemon) jrpc2.Handler {
Expand Down
4 changes: 2 additions & 2 deletions cmd/soroban-rpc/internal/methods/simulate_transaction.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,8 @@ func (l *LedgerEntryChange) FromXDRDiff(diff preflight.XDRDiff) error {
return nil
}

// LedgerEntryChange designates a change in a ledger entry. Before and After cannot be be omitted at the same time.
// If Before is omitted, it constitutes a creation, if After is omitted, it constitutes a delation.
// LedgerEntryChange designates a change in a ledger entry. Before and After cannot be omitted at the same time.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct the typo here by the way.

// If Before is omitted, it constitutes a creation, if After is omitted, it constitutes a deletion.
type LedgerEntryChange struct {
Type LedgerEntryChangeType `json:"type"`
Key string `json:"key"` // LedgerEntryKey in base64
Expand Down
Loading