Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soroban-rpc: ingestion engine should set user-agent header on history archive requests #8

Closed
mollykarcher opened this issue Jan 16, 2024 · 1 comment · Fixed by #56
Closed

soroban-rpc: ingestion engine should set user-agent header on history archive requests #8

mollykarcher opened this issue Jan 16, 2024 · 1 comment · Fixed by #56
Assignees
@sreuland
Labels
bug Something isn't working

Comments

@mollykarcher
Copy link
Contributor

mollykarcher commented Jan 16, 2024 •
edited by sreuland
Loading

What version are you using?

20.2.0

What did you do?

run rpc server

What did you expect to see?

  • outbound http archive url requests initiated by rpc server's ingestion should have the http header User-Agent: "horizon/<horizon_version> golang/<go_mod_version>
  • a prometheus metric is emitted for the history archive request

What did you see instead?

the outbound archive url request has the default golang http header instead User-Agent: "Go-http-client, no metrics for history archive request emitted.

See parent/root issue stellar/go#5163
@mollykarcher mollykarcher added the bug Something isn't working label Jan 16, 2024
@mollykarcher mollykarcher mentioned this issue Jan 16, 2024
Closed
15 tasks
@sreuland
Copy link
Contributor

this depends on stellar/go#5161 to merge to the 2.28.0 release branch first, for updates to the historyarchive package which is used by rpc ingestion and imported via go.mod

@stellarsaur stellarsaur transferred this issue from stellar/stellar-cli Feb 1, 2024
sreuland added a commit that referenced this issue Feb 8, 2024
@sreuland
#8: added user agent and archive pool metrics
2ed8616
@sreuland sreuland mentioned this issue Feb 8, 2024
Merged
sreuland added a commit that referenced this issue Feb 8, 2024
@sreuland
#8: fixed format warning
b38b813
@sreuland sreuland moved this from In Progress to Needs Review in Platform Scrum Feb 9, 2024
sreuland added a commit that referenced this issue Feb 9, 2024
@sreuland
#8: don't use history archive caching for rpc, no need for metrics si…
2c465a5 
…nce archive usage is very limited
sreuland added a commit that referenced this issue Feb 9, 2024
@sreuland
#8: added integration test coverage to assert user agent config on hi…
5028a92 
…story archives
sreuland added a commit that referenced this issue Feb 9, 2024
@sreuland
#8: removed cache config struct from archive pool config struct for d…
0600fe9 
…efault disablement
sreuland added a commit that referenced this issue Feb 12, 2024
@sreuland
#8: make the test config params proper, per review feedback
cdf9481
@github-project-automation github-project-automation bot moved this from Needs Review to Done in Platform Scrum Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sreuland sreuland

Labels
bug Something isn't working
Projects
Platform Scrum
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rpc: added user agent config on ha archive pool stellar/stellar-rpc
3 participants
@mollykarcher @sreuland and others