Fix review comments.

stellar · Feb 8, 2024 · bb8872a · bb8872a
1 parent ffb9d90
commit bb8872a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/cmd/soroban-rpc/internal/transactions/transactions.go b/cmd/soroban-rpc/internal/transactions/transactions.go
@@ -200,18 +200,18 @@ func (m *MemoryStore) GetTransaction(hash xdr.Hash) (Transaction, bool, StoreRan
 		return Transaction{}, false, storeRange
 	}
 
-	var tx_meta xdr.TransactionMeta
-	err := tx_meta.UnmarshalBinary(internalTx.meta)
+	var txMeta xdr.TransactionMeta
+	err := txMeta.UnmarshalBinary(internalTx.meta)
 	if err != nil {
 		return Transaction{}, false, storeRange
 	}
 
-	txEvents, err := tx_meta.GetDiagnosticEvents()
+	txEvents, err := txMeta.GetDiagnosticEvents()
 	if err != nil {
 		return Transaction{}, false, storeRange
 	}
 
-	var events [][]byte
+	events := make([][]byte, 0, len(txEvents))
 
 	for _, e := range txEvents {
 		diagnosticEventXDR, err := e.MarshalBinary()

diff --git a/cmd/soroban-rpc/internal/transactions/transactions_test.go b/cmd/soroban-rpc/internal/transactions/transactions_test.go
@@ -359,6 +359,7 @@ func TestGetTransactionsWithEventData(t *testing.T) {
 	tx, ok, _ := store.GetTransaction(txHash(1, false))
 	require.True(t, ok)
 	require.NotNil(t, tx.Events)
+	require.Equal(t, 1, len(tx.Events))
 
 }