Omit encoding txdata on errors

stellar · Aug 20, 2024 · 323c21f · 323c21f
1 parent 6ef7e75
commit 323c21f
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/cmd/soroban-rpc/internal/methods/simulate_transaction.go b/cmd/soroban-rpc/internal/methods/simulate_transaction.go
@@ -398,13 +398,15 @@ func NewSimulateTransactionHandler(logger *log.Entry, ledgerEntryReader db.Ledge
 
 		switch request.Format {
 		case FormatJSON:
-			simResp.TransactionDataJSON, err = xdr2json.ConvertBytes(
-				xdr.SorobanTransactionData{},
-				result.TransactionData)
-			if err != nil {
-				return SimulateTransactionResponse{
-					Error:        err.Error(),
-					LatestLedger: latestLedger,
+			if len(result.TransactionData) > 0 {
+				simResp.TransactionDataJSON, err = xdr2json.ConvertBytes(
+					xdr.SorobanTransactionData{},
+					result.TransactionData)
+				if err != nil {
+					return SimulateTransactionResponse{
+						Error:        err.Error(),
+						LatestLedger: latestLedger,
+					}
 				}
 			}