Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: add cap diff check #950

Merged
merged 8 commits into from
May 28, 2021
Merged

meta: add cap diff check #950

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fa3e187
meta: add cap diff check
leighmcculloch May 25, 2021
ad7255c
meta: update mddiffcheck param prefix
leighmcculloch May 25, 2021
5a0c1bc
Skip the GOPROXY on downloads to get latest version
leighmcculloch May 25, 2021
a710721
Use the GOPROXY on downloads
leighmcculloch May 25, 2021
4d73bb0
Try without setup-go
leighmcculloch May 26, 2021
1a93f43
Remove @latest in install
leighmcculloch May 26, 2021
e46bce9
Require Go 1.16 to be setup
leighmcculloch May 26, 2021
83bbac0
Merge branch 'master' into mddiffcheck
leighmcculloch May 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .github/workflows/mddiffcheck.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
name: 'Check CAP Diffs'

on:
push:
branches:
- master
pull_request:

jobs:
mddiffcheck:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Set up Go
leighmcculloch marked this conversation as resolved.
Show resolved Hide resolved
uses: actions/setup-go@v2
with:
go-version: 1
leighmcculloch marked this conversation as resolved.
Show resolved Hide resolved
- run: go get github.com/stellar/mddiffcheck@latest
- run: mddiffcheck -repo https://github.com/stellar/stellar-core core/*.md
2 changes: 1 addition & 1 deletion core/cap-0021.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ the same block.

### XDR diff

```diff
```diff mddiffcheck.base=v16.0.0
diff --git a/src/xdr/Stellar-ledger-entries.x b/src/xdr/Stellar-ledger-entries.x
index 26ff33d43..d96f55ea6 100644
--- a/src/xdr/Stellar-ledger-entries.x
Expand Down
2 changes: 1 addition & 1 deletion core/cap-0035.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ flags. This operation can be used to unset `TRUSTLINE_CLAWBACK_ENABLED_FLAG`.

This patch of XDR changes is based on the XDR files in tag/commit `v15.1.0` (`90b2780584c6390207bf09291212d606896ce9f8`) of [stellar-core].

```diff
```diff mddiffcheck.ignore=true
MonsieurNicolas marked this conversation as resolved.
Show resolved Hide resolved
diff --git a/src/xdr/Stellar-ledger-entries.x b/src/xdr/Stellar-ledger-entries.x
index 8d7463915..26ff33d43 100644
--- a/src/xdr/Stellar-ledger-entries.x
Expand Down
2 changes: 1 addition & 1 deletion core/cap-0036.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ destroyed as if it had been claimed by a claimaint.

This patch of XDR changes is based on the XDR files as they are after the XDR changes from CAP-35 are applied.

```diff
```diff mddiffcheck.ignore=true
--- a/src/xdr/Stellar-transaction.x
+++ b/src/xdr/Stellar-transaction.x
@@ -47,7 +47,8 @@ enum OperationType
Expand Down
6 changes: 3 additions & 3 deletions core/cap-0037.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ their funds to the pool, participating in the collective liquidity allocation.

### XDR changes

```diff
```diff mddiffcheck.ignore=true
--- a/src/xdr/Stellar-ledger-entries.x
+++ b/src/xdr/Stellar-ledger-entries.x
@@ -403,6 +403,43 @@ struct ClaimableBalanceEntry
Expand Down Expand Up @@ -165,7 +165,7 @@ their funds to the pool, participating in the collective liquidity allocation.
};
```

```diff
```diff mddiffcheck.ignore=true
--- a/src/xdr/Stellar-transaction.x
+++ b/src/xdr/Stellar-transaction.x
@@ -48,7 +48,9 @@ enum OperationType
Expand Down Expand Up @@ -647,4 +647,4 @@ every `LiquidityPoolEntry` requires at least one `LiquidityStakeEntry`.

## Security Concerns

TBD
TBD
2 changes: 1 addition & 1 deletion core/cap-0038.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ exchanging assets with the order book and liquidity pools.

### XDR changes
This patch of XDR changes is based on the XDR files in commit (`afb2dca9e112c79547e5125c1e45a8e94c9b965b`) of stellar-core.
```diff
```diff mddiffcheck.base=afb2dca9e112c79547e5125c1e45a8e94c9b965b
diff --git a/src/xdr/Stellar-ledger-entries.x b/src/xdr/Stellar-ledger-entries.x
index 0e7bc842b..73a170019 100644
--- a/src/xdr/Stellar-ledger-entries.x
Expand Down
2 changes: 1 addition & 1 deletion core/cap-0039.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ accounts for contracts, such as payment channels.
This patch of XDR changes is based on the XDR files in commit
`b9e10051eafa1125e8d238a47e5915dad30c2640` of stellar-core.

```diff
```diff mddiffcheck.base=b9e10051eafa1125e8d238a47e5915dad30c2640
diff --git a/src/xdr/Stellar-ledger-entries.x b/src/xdr/Stellar-ledger-entries.x
index 0e7bc842..68c52758 100644
--- a/src/xdr/Stellar-ledger-entries.x
Expand Down