Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CAP-0009 Linear/Exterior Immutable Accounts #210

Merged
merged 1 commit into from
Jan 3, 2019
Merged

Add CAP-0009 Linear/Exterior Immutable Accounts #210

merged 1 commit into from
Jan 3, 2019

Conversation

JeremyRubin
Copy link
Contributor

No description provided.

danrobinson
danrobinson reviewed Dec 6, 2018
View reviewed changes
core/cap-0009.md

If `AUTH_EXTERIOR_IMMUTABLE` is set, then transactions which attempt to modify
the state of the account in any way are either invalid or fail (determined by
`AUTH_EXTERIOR_IMMUTABLE_ACTION` -- set : fail, unset : invalid), unless the modification occurs as a result of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can support an "invalid" option. Allowing a destination account in a payment to make the payment transaction invalid is not currently possible and would break Starlight and possibly other protocols, in a way that, as far as I can tell, does not have a straightforward workaround.

@tomerweller
Copy link
Contributor

AUTH_PARTIAL_LINEAR is a great addition to Stellar's compliance story as it can facilitate a sign-to-receive scheme, essentially enforcing SEP0003. Merchants have asked for something like this. Though, can someone think of a better name?

While I understand the need for something like AUTH_EXTERIOR_IMMUTABLE and AUTH_EXTERIOR_IMMUTABLE_ACTION, this sounds a bit cumbersome. I vaguely remember @jonjove commenting that if removing trustlines is the main use case, it can be achieved by adding an exterior immutable flag to trustlines rather than to the account. @jonjove?

@jedmccaleb jedmccaleb merged commit 03d41ae into stellar:master Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danrobinson danrobinson danrobinson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JeremyRubin @tomerweller @danrobinson @jedmccaleb