Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEP-6: Make account_id optional in withdraw response #1417

Merged
merged 2 commits into from
Nov 1, 2023
Merged

SEP-6: Make account_id optional in withdraw response #1417

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b2e915
SEP-6: Make `account_id` optional in withdraw response
philipliu Oct 31, 2023
70af149
Update success response descriptions
philipliu Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ecosystem/sep-0006.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ Title: Deposit and Withdrawal API
Author: SDF
Status: Active (Interactive components are deprecated in favor of SEP-24)
Created: 2017-10-30
Updated: 2023-10-20
Version 3.23.0
Updated: 2023-10-31
Version 3.24.0
```

## Simple Summary
Expand Down Expand Up @@ -611,7 +611,8 @@ The response body should be a JSON object with the following fields:

Name | Type | Description
-----|------|------------
`account_id` | `G...` string | The account the user should send its token back to.
`account_id` | `G...` string | (optional) The account the user should send its token back to. This field can be omitted if the anchor cannot provide this information at the time of the request.
In this case, the wallet should query the [`/transaction`](#single-historical-transaction) endpoint to get this asynchonously.
`memo_type` | string | (optional) Type of memo to attach to transaction, one of `text`, `id` or `hash`.
`memo` | string | (optional) Value of memo to attach to transaction, for `hash` this should be base64-encoded. The anchor should use this memo to match the Stellar transaction with the database entry associated created to represent it.
`id` | string | (optional) The anchor's ID for this withdrawal. The wallet will use this ID to query the [`/transaction`](#single-historical-transaction) endpoint to check status of the request.
Expand Down Expand Up @@ -1484,6 +1485,7 @@ If the information was malformed, or if the sender tried to update data that isn
[SEP-38]: sep-0038.md

## Changelog
- `v3.24.0`: Make `account_id` optional in withdraw response ([#1417](https://github.com/stellar/stellar-protocol/pull/1417))
- `v3.23.0`: Add `customer_id` field to deposit and withdrawal requests ([#1410](https://github.com/stellar/stellar-protocol/pull/1410))
- `v3.22.0`: Deprecate the `wallet_name` and `wallet_url` parameters of `deposit` and `withdraw` requests ([#1393](https://github.com/stellar/stellar-protocol/pull/1393))
* `v3.21.0`: Accept financial information via SEP-12. ([#1379](https://github.com/stellar/stellar-protocol/pull/1380/))
Expand Down
Loading