Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEP-6: Deprecate wallet name and url #1393

Merged
merged 5 commits into from
Sep 11, 2023
Merged

SEP-6: Deprecate wallet name and url #1393

merged 5 commits into from
Sep 11, 2023

Conversation

Ifropc
Copy link
Contributor

@Ifropc Ifropc commented Sep 8, 2023

See #1364

Copy link
Contributor

@JakeUrban JakeUrban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets run prettier to keep the formatting consistent, but LGTM

@@ -1481,6 +1482,7 @@ If the information was malformed, or if the sender tried to update data that isn

## Changelog

- `v3.2.0`: Deprecate the `wallet_name` and `wallet_url` parameters of `deposit` and `withdraw` requests ([#1393](https://github.com/stellar/stellar-protocol/pull/1393))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `v3.2.0`: Deprecate the `wallet_name` and `wallet_url` parameters of `deposit` and `withdraw` requests ([#1393](https://github.com/stellar/stellar-protocol/pull/1393))
- `v3.22.0`: Deprecate the `wallet_name` and `wallet_url` parameters of `deposit` and `withdraw` requests ([#1393](https://github.com/stellar/stellar-protocol/pull/1393))

@Ifropc
Copy link
Contributor Author

Ifropc commented Sep 8, 2023

I will run prettier in a separate PR

Copy link
Contributor

@philipliu philipliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ifropc Ifropc merged commit 7d2ecd0 into master Sep 11, 2023
2 checks passed
@JakeUrban JakeUrban deleted the deprecate-wallet-name branch September 11, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants