-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh events CAP #1371
Refresh events CAP #1371
Conversation
core/cap-0046-08.md
Outdated
that the user can fill out with smaller values so downstream systems can provide | ||
more narrow filtering and subscription options without prior knowledge of the | ||
`data` format. There can only be four topics, and if the type is `Bytes`, cannot | ||
be more than 64 bytes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This 64 byte limit doesn't make much sense and should probably be removed. You can bypass it by using a Vec or String.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's probably worthwhile specifying the event limits more clearly.
- Should the topics size be network configurable?
4
seems a bit arbitrary and too restrictive. - Should there be a size limit in both the topics and data? Unbounded events means contracts can submit a single event up to 500k (meta data size limit) repeatedly, causing downstream stress in processing them.
No description provided.