Refresh events CAP #1371
Merged
Refresh events CAP #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisuresh
commented
Jul 14, 2023
core/cap-0046-08.md
Outdated
| that the user can fill out with smaller values so downstream systems can provide | ||
| more narrow filtering and subscription options without prior knowledge of the | ||
| `data` format. There can only be four topics, and if the type is `Bytes`, cannot | ||
| be more than 64 bytes. |
There was a problem hiding this comment.
This 64 byte limit doesn't make much sense and should probably be removed. You can bypass it by using a Vec or String.
There was a problem hiding this comment.
I think it's probably worthwhile specifying the event limits more clearly.
- Should the topics size be network configurable?
4seems a bit arbitrary and too restrictive. - Should there be a size limit in both the topics and data? Unbounded events means contracts can submit a single event up to 500k (meta data size limit) repeatedly, causing downstream stress in processing them.
dmkozh
reviewed
Aug 10, 2023
dmkozh
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.