Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEP-24: add updated_at field to transaction records #1329

Merged
merged 3 commits into from
Dec 22, 2022

Conversation

howardtw
Copy link
Contributor

@howardtw howardtw commented Dec 22, 2022

What

Add updated_at field to the transaction object.

Why

In the event of the anchor sends a callback with an older timestamp than the one that a wallet has proceeded, the callback can be safely discarded by the wallet.

@howardtw howardtw requested a review from JakeUrban December 22, 2022 20:35
JakeUrban
JakeUrban previously approved these changes Dec 22, 2022
Copy link
Contributor

@JakeUrban JakeUrban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, do you mind adding an entry to the changelog at the bottom before merging?

ecosystem/sep-0024.md Outdated Show resolved Hide resolved
@howardtw howardtw changed the title SEP-24: add updated_at field to transaction object SEP-24: add updated_at field to transaction records Dec 22, 2022
@howardtw
Copy link
Contributor Author

Looks great, do you mind adding an entry to the changelog at the bottom before merging?

Done in this commit.

@howardtw howardtw requested a review from JakeUrban December 22, 2022 21:00
@howardtw howardtw merged commit 9e63375 into master Dec 22, 2022
@MonsieurNicolas MonsieurNicolas deleted the sep24-status-timestamp branch October 30, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants